Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete HTML displaying errors incorrectly #16981

Closed
DartBot opened this issue Feb 20, 2014 · 7 comments
Closed

Incomplete HTML displaying errors incorrectly #16981

DartBot opened this issue Feb 20, 2014 · 7 comments
Assignees
Milestone

Comments

@DartBot
Copy link

DartBot commented Feb 20, 2014

This issue was originally filed by LukeEC...@gmail.com


With a structure with insufficient end div tags

e.g.

<html>
  <body>
    <div>
      <div>

      </div>
</body>

A warning is displayed associated with the /body tag below:

"web/....html:163:1: Unexpected end tag (div). Missing end tag (body)."

It should be reporting that there was a missing end tag for (div) instead. This made fixing the difficult slightly tricky.

The page used polymer.

@clayberg
Copy link

cc @scheglov.
Set owner to @stevemessick.
Added this to the 1.3 milestone.

@stevemessick
Copy link
Contributor

Brian, do you know if this warning is produced by the analyzer? When I add a file with Luke's html structure the wst verifier correctly marks the first div-tag as having no closing tag.


Set owner to @bwilkerson.
Added NeedsInfo label.

@DartBot
Copy link
Author

DartBot commented Feb 20, 2014

This comment was originally written by LukeEC...@gmail.com


If you need the original, somewhat complex HTML, let me know and I'll try and get it back to that state. I didn't send it originally as I thought it would just confuse the issue

@sigmundch
Copy link
Member

Hi Luke

Thanks for the error report, this seems like a bug in the html5lib error reporting.

To be more specific, polymer uses html5lib to parse html. This package includes warnings for many of the implicit rules in HTML. The message should have been swapped in this case:

   Unexpected end tag (body). Missing end tag (div).

I'll send out a fix shortly.


Set owner to @sigmundch.
Removed Area-Editor label.
Added Area-Polymer, Pkg-Html5Lib, Started labels.

@sigmundch
Copy link
Member

@jmesserly
Copy link

siggi just checked in a fix


Added Fixed label.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

This issue has been moved to dart-lang/html#33.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants