Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[next] addEventListener does not go through zones #17406

Closed
blois opened this issue Mar 11, 2014 · 11 comments
Closed

[next] addEventListener does not go through zones #17406

blois opened this issue Mar 11, 2014 · 11 comments
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-obsolete Closed as the reported issue is no longer relevant library-html type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@blois
Copy link
Contributor

blois commented Mar 11, 2014

The streams do, but addEventListener does not.

@blois
Copy link
Contributor Author

blois commented Mar 11, 2014

The difficulty here is that in Dartium we have to have multiple implementations of addEventListener to work around 17408.

In order to wrap in zones we would make addEventListener private and expose a new public one which does the wrapping, but this is susceptible to subtle breakage (and invalid C++ casts) if the C++ classes change.

@blois
Copy link
Contributor Author

blois commented Mar 11, 2014

Marked this as being blocked by #17408.

@kevmoo
Copy link
Member

kevmoo commented Apr 7, 2014

Removed Area-HTML label.
Added Area-Library, Library-Html labels.

@blois
Copy link
Contributor Author

blois commented Jun 17, 2014

Issue #19508 has been merged into this issue.

@jmesserly
Copy link

idea: rename native method to addEventListenerWithoutZone, then introduce a written-in-dart addEventListener?

Pete any ideas how to support removeEventListener? I guess we'll need to associate our wrapped function with the original function closure using an Expando.

@sethladd
Copy link
Contributor

What's the priority of this issue?

@blois
Copy link
Contributor Author

blois commented Jul 9, 2014

Perhaps deprecate removeEventListener and just have removeEventListenerWithoutZone?

@blois
Copy link
Contributor Author

blois commented Jul 9, 2014

Issue #19905 has been merged into this issue.

@alan-knight
Copy link
Contributor

Might be addressed in the next rev.


Removed the owner.
Changed the title to: "[next] addEventListener does not go through zones".

@jacob314
Copy link
Member

jacob314 commented Mar 9, 2015

Angular2 has to work around this issue resulting in less efficient codegen.
https://github.com/angular/angular/blob/60885da0445bc62f065c6c6d8e805a930295783e/modules/angular2/src/dom/browser_adapter.dart

@blois blois added Type-Defect area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-html labels Mar 9, 2015
@kevmoo kevmoo added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed priority-unassigned labels Feb 29, 2016
@matanlurey matanlurey added the closed-obsolete Closed as the reported issue is no longer relevant label Jun 19, 2018
@matanlurey
Copy link
Contributor

I believe we are not planning on forcing all JS interop through zones at this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-obsolete Closed as the reported issue is no longer relevant library-html type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

7 participants