Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use list-package-dirs rather than symlinks in the analyzer #19742

Closed
nex3 opened this issue Jul 1, 2014 · 15 comments
Closed

Use list-package-dirs rather than symlinks in the analyzer #19742

nex3 opened this issue Jul 1, 2014 · 15 comments
Assignees
Labels
analyzer-command Issues with the command-line dartanalyzer tool area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion.

Comments

@nex3
Copy link
Member

nex3 commented Jul 1, 2014

Pub is planning on no longer producing package symlinks (issue #15103), but currently the analyzer relies on these symlinks to resolve "package:" imports. Ultimately it would be good for the analyzer to look up packages through barback, but until then it should use "pub list-package-dirs" to find the dependency paths so pub can safely cease producing symlinks.

@nex3
Copy link
Member Author

nex3 commented Jul 1, 2014

Marked this as blocking #15103.

@bwilkerson
Copy link
Member

Pub is planning on no longer producing package symlinks ...

De we have a time-frame for when this will likely happen?

@nex3
Copy link
Member Author

nex3 commented Jul 1, 2014

Do we have a time-frame for when this will likely happen?

It's blocked on this issue, but we'd like to do it as soon as we can without breaking the ecosystem. It's the third most-starred pub issue.

@bwilkerson
Copy link
Member

Added this to the 1.6 milestone.
Removed Type-Enhancement, Priority-Unassigned labels.
Added Type-Defect, Priority-High, Analyzer-Command labels.

@sethladd
Copy link
Contributor

Marked as High, assigning owner. If I get this wrong, please help me by:

* assigning a new owner

  • changing priority
  • changing milestone

Set owner to @danrubel.

@sethladd
Copy link
Contributor

Anything we can do to remove symlinks is a good thing.

@bwilkerson
Copy link
Member

Added Started label.

@danrubel
Copy link

Implemented behind a flag in editor, but not tested so not enabled by default
https://codereview.chromium.org/439933005/


Removed this from the 1.6 milestone.
Added this to the 1.7 milestone.

@munificent
Copy link
Member

Woo!

@bwilkerson
Copy link
Member

Removed this from the 1.7 milestone.
Added this to the 1.8 milestone.

@nex3
Copy link
Member Author

nex3 commented Sep 25, 2014

What's the status on this? Is it going to be enabled by default soon?

@danrubel
Copy link

danrubel commented Nov 4, 2014

Not ready for 1.8


Removed this from the 1.8 milestone.
Removed Priority-High label.
Added Priority-Medium, Triaged labels.

@bwilkerson
Copy link
Member

Set owner to @pq.

@nex3 nex3 added Type-Defect area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. analyzer-command Issues with the command-line dartanalyzer tool labels Apr 22, 2015
@nex3 nex3 assigned pq Apr 22, 2015
@sethladd
Copy link
Contributor

sethladd commented Sep 3, 2015

Is this still required?

Tracking down everything we need for #24112

@pq
Copy link
Member

pq commented Sep 3, 2015

Nope. Closing out. Thanks!

@pq pq closed this as completed Sep 3, 2015
@kevmoo kevmoo removed the triaged label Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzer-command Issues with the command-line dartanalyzer tool area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion.
Projects
None yet
Development

No branches or pull requests

7 participants