Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csslib does not support escaping within strings #20095

Closed
skoga opened this issue Jul 17, 2014 · 3 comments
Closed

csslib does not support escaping within strings #20095

skoga opened this issue Jul 17, 2014 · 3 comments
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams.

Comments

@skoga
Copy link

skoga commented Jul 17, 2014

What steps will reproduce the problem?

Consider parsing the following:

.foo {
  desc: "I'm cool";
}

.bar {
  desc: "I\000027m hot";
}

According to the W3c spec (http://www.w3.org/TR/css3-syntax/#escaping) Both of the above strings are legit and should result in the visitor calling visitLiteralTerm with the the string "I'm hot" or "I'm cold" (as appropriate).

However, visitLiteralTerm comes back with the string "I\000027m hot" and (escaped dart string) and "I\000027m cold". So it looks like some kind of translation occurs but it's not in the correct direction.

What version of the product are you using?

csslib 0.9.2

On what operating system?

linux

What browser (if applicable)?

server-side (n/a)

Please provide any additional information below.

@skoga
Copy link
Author

skoga commented Jul 17, 2014

I should note that something of the form

.baz {
  desc: "I'm bad"
}

should be parsed correctly from my reading of the syntax spec, but it will fail to parse in csslib. This will parse correctly in sass, btw.

@sethladd
Copy link
Contributor

cc @terrylucas.
Added Pkg-Csslib, Area-Pkg, Triaged labels.

@skoga skoga added Type-Defect area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. labels Jul 18, 2014
@DartBot
Copy link

DartBot commented Jun 5, 2015

This issue has been moved to dart-lang/csslib#11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams.
Projects
None yet
Development

No branches or pull requests

4 participants