Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in args README and code snippet #20224

Closed
DartBot opened this issue Jul 27, 2014 · 6 comments
Closed

Typo in args README and code snippet #20224

DartBot opened this issue Jul 27, 2014 · 6 comments
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams.

Comments

@DartBot
Copy link

DartBot commented Jul 27, 2014

This issue was originally filed by @sethladd


http://pub.dartlang.org/packages/args

parser.addOption('out', help: 'The output path', helpValue: 'path',

(notice the helpValue)

However, according to the docs:

void addOption(String name, {String abbr, String help, String valueHelp, List<String> allowed, Map<String, String> allowedHelp, String defaultsTo, Function void callback(value), bool allowMultiple: false, bool hide: false})

(notice valueHelp)

@DartBot
Copy link
Author

DartBot commented Jul 27, 2014

This comment was originally written by @sethladd


Can't wait to get these packages onto Github... fixing this would be so easy! :)

@sethladd
Copy link
Contributor

Added Area-Pkg, Pkg-Args, Triaged labels.

@sethladd
Copy link
Contributor

Hi Bob,

I was just bit by this again. (will I ever learn?!?)

Is this something we can fix relatively soon?

Not sure what is correct:

helpValue or valueHelp ?


cc @munificent.

@srawlins
Copy link
Member

srawlins commented Oct 7, 2014

Set owner to @srawlins.
Added Started label.

@srawlins
Copy link
Member

srawlins commented Oct 7, 2014

Added Fixed label.

@DartBot DartBot added Type-Defect area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. labels Oct 7, 2014
@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

This issue has been moved to dart-lang/args#34.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams.
Projects
None yet
Development

No branches or pull requests

4 participants