Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VM: Implement Isolate.addErrorListener. #21188

Closed
lrhn opened this issue Oct 1, 2014 · 9 comments
Closed

VM: Implement Isolate.addErrorListener. #21188

lrhn opened this issue Oct 1, 2014 · 9 comments
Assignees
@iposva-google
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends.
Milestone
1.9

Comments

@lrhn
Copy link
Member

lrhn commented Oct 1, 2014

Make it possible to receive uncaught errors from isolates by implementing Isolate.addErrorListener.
@lrhn
Copy link
Member Author

lrhn commented Oct 1, 2014

This would also include Isolate.removeErrorListener.

@sgjesse
Copy link
Contributor

sgjesse commented Nov 13, 2014

Marked this as blocking #21599.

@sgjesse
Copy link
Contributor

sgjesse commented Nov 13, 2014

Added this to the 1.9 milestone.

@iposva-google
Copy link
Contributor

Set owner to @iposva-google.
Added Started label.

@sethladd
Copy link
Contributor

Marked this as blocking #22067.

@DartBot
Copy link

DartBot commented Feb 15, 2015

This comment was originally written by george.moscho...@gmail.com

Why the javascriptish name? Why not:

isolate.onError.listen(handler);

?

@lrhn
Copy link
Member Author

lrhn commented Feb 15, 2015

The "addErrorListener" is a low-level function, working directly on ports, so it's named for precision, not brevity.

There is also a more high-level "Isolate.errors" stream that you can listen to. It's implemented in terms of addErrorListener.

@sethladd
Copy link
Contributor

sethladd commented Mar 8, 2015

Are we still targeting 1.9 for this?

@iposva-google
Copy link
Contributor

r44307

Added Fixed label.

@lrhn lrhn added Type-Defect area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. labels Mar 11, 2015
@lrhn lrhn added this to the 1.9 milestone Mar 11, 2015
@iposva-google iposva-google mentioned this issue Jun 3, 2015
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iposva-google iposva-google

Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends.
Projects
None yet
Milestone
1.9
Development

No branches or pull requests
6 participants
@sethladd @kevmoo @sgjesse @lrhn @iposva-google @DartBot