Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable process tests when command-line arguments can be passed #213

Closed
madsager opened this issue Oct 24, 2011 · 3 comments
Closed

Enable process tests when command-line arguments can be passed #213

madsager opened this issue Oct 24, 2011 · 3 comments
Assignees
@sgjesse
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. closed-duplicate Closed in favor of an existing report

Comments

@madsager
Copy link
Contributor

Currently, all process tests are disabled except for on Linux in debug mode. We need command-line arguments to be able to pass in the name of the binary to start. Once that is available we need to enable the process tests.
@DartBot
Copy link

DartBot commented Oct 24, 2011

This comment was originally written by jrgf...@google.com

Please take a look at http://codereview.chromium.org/8365032/

I have fixed this problem in another way but I still can't commit the fix, since it's blocked by a bug in the event loop for which I have also uploaded a CL (http://codereview.chromium.org/8362026/).

@madsager
Copy link
Contributor Author

Added Duplicate label.
Marked as being merged into #179.

@madsager
Copy link
Contributor Author

Marked as being merged into #172.

@madsager madsager added Type-Defect area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. closed-duplicate Closed in favor of an existing report labels Oct 24, 2011
This was referenced Jun 3, 2015
Closed
Closed
@MananKakadiya MananKakadiya mentioned this issue Sep 25, 2018
Closed
This was referenced Oct 29, 2020
Open
Closed
Closed
This was referenced Nov 5, 2020
Closed
Open
@KTOLE18 KTOLE18 mentioned this issue Aug 10, 2021
Closed
@mmukagali mmukagali mentioned this issue Dec 2, 2022
Closed
@Mufaddal1125 Mufaddal1125 mentioned this issue May 13, 2023
Closed
copybara-service bot pushed a commit that referenced this issue May 15, 2023
@devoncarew
[deps] rev args, async, bazel_worker, benchmark_harness, boolean_sele…
e3ba855 
…ctor, browser_launcher, file, mockito, tools, dartdoc

Revisions updated by `dart tools/rev_sdk_deps.dart`.

dartdoc to 0cf21c15d7346a81838bd1c56677d88d690887f5

args (https://github.com/dart-lang/args/compare/1864048..f0f6cd2):
  f0f6cd2  2023-05-12  Devon Carew  blast_repo fixes (#243)

async (https://github.com/dart-lang/async/compare/0f368d3..d744058):
  d744058  2023-05-12  Devon Carew  blast_repo fixes (#242)

bazel_worker (https://github.com/dart-lang/bazel_worker/compare/1b86d3c..d9b389f):
  d9b389f  2023-05-12  Devon Carew  blast_repo fixes (#73)

benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/f81b042..e717ad4):
  e717ad4  2023-05-12  Devon Carew  blast_repo fixes (#90)

boolean_selector (https://github.com/dart-lang/boolean_selector/compare/7eed402..23e08e0):
  23e08e0  2023-05-12  Devon Carew  blast_repo fixes (#47)

browser_launcher (https://github.com/dart-lang/browser_launcher/compare/551e101..40e4315):
  40e4315  2023-05-12  Devon Carew  blast_repo fixes (#45)

file (https://github.com/google/file.dart/compare/e90e5ed..f05f5db):
  f05f5db  2023-05-15  James D. Lin  Make MemoryFile.openRead and _ChrootFile.openRead return Stream<List<int>> again (#217)
  f2f3076  2023-05-12  Ross Wang  MemoryFileSystem addStream onError (#220)
  5e76f74  2023-05-12  James D. Lin  Fix MemoryFileSystem to treat an empty path as non-existent (#213)
  7941466  2023-05-12  James D. Lin  Make `FileSystem.isLink` actually work (#214)

mockito (https://github.com/dart-lang/mockito/compare/51a7728..b14d571):
  b14d571  2023-05-15  Googler  Fix for InvalidType

tools (https://github.com/dart-lang/tools/compare/62c9604..49da4ca):
  49da4ca  2023-05-12  Polina Cherkasova  Add memory events. (#92)

Change-Id: I582320bb68ff5f48e9969cef906073e25ad6b875
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/303380
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
copybara-service bot pushed a commit that referenced this issue May 16, 2023
@yanok
Revert "[deps] rev args, async, bazel_worker, benchmark_harness, bool…
126a941 
…ean_selector, browser_launcher, file, mockito, tools, dartdoc"

This reverts commit e3ba855.

Reason for revert: b/282823291, breaks Flutter tests at least on Android.

Original change's description:
> [deps] rev args, async, bazel_worker, benchmark_harness, boolean_selector, browser_launcher, file, mockito, tools, dartdoc
>
> Revisions updated by `dart tools/rev_sdk_deps.dart`.
>
> dartdoc to 0cf21c15d7346a81838bd1c56677d88d690887f5
>
> args (https://github.com/dart-lang/args/compare/1864048..f0f6cd2):
>   f0f6cd2  2023-05-12  Devon Carew  blast_repo fixes (#243)
>
> async (https://github.com/dart-lang/async/compare/0f368d3..d744058):
>   d744058  2023-05-12  Devon Carew  blast_repo fixes (#242)
>
> bazel_worker (https://github.com/dart-lang/bazel_worker/compare/1b86d3c..d9b389f):
>   d9b389f  2023-05-12  Devon Carew  blast_repo fixes (#73)
>
> benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/f81b042..e717ad4):
>   e717ad4  2023-05-12  Devon Carew  blast_repo fixes (#90)
>
> boolean_selector (https://github.com/dart-lang/boolean_selector/compare/7eed402..23e08e0):
>   23e08e0  2023-05-12  Devon Carew  blast_repo fixes (#47)
>
> browser_launcher (https://github.com/dart-lang/browser_launcher/compare/551e101..40e4315):
>   40e4315  2023-05-12  Devon Carew  blast_repo fixes (#45)
>
> file (https://github.com/google/file.dart/compare/e90e5ed..f05f5db):
>   f05f5db  2023-05-15  James D. Lin  Make MemoryFile.openRead and _ChrootFile.openRead return Stream<List<int>> again (#217)
>   f2f3076  2023-05-12  Ross Wang  MemoryFileSystem addStream onError (#220)
>   5e76f74  2023-05-12  James D. Lin  Fix MemoryFileSystem to treat an empty path as non-existent (#213)
>   7941466  2023-05-12  James D. Lin  Make `FileSystem.isLink` actually work (#214)
>
> mockito (https://github.com/dart-lang/mockito/compare/51a7728..b14d571):
>   b14d571  2023-05-15  Googler  Fix for InvalidType
>
> tools (https://github.com/dart-lang/tools/compare/62c9604..49da4ca):
>   49da4ca  2023-05-12  Polina Cherkasova  Add memory events. (#92)
>
> Change-Id: I582320bb68ff5f48e9969cef906073e25ad6b875
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/303380
> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
> Commit-Queue: Devon Carew <devoncarew@google.com>

Change-Id: Ifc2aa278a47a4060f2be28c1950084eb0c2de812
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/303720
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Ilya Yanok <yanok@google.com>
@eernstg eernstg mentioned this issue Dec 21, 2023
Open
copybara-service bot pushed a commit that referenced this issue Jan 2, 2024
@devoncarew
[deps] rev benchmark_harness, cli_util, convert, crypto, csslib, ecos…
807f2a3 
…ystem, json_rpc_2

Revisions updated by `dart tools/rev_sdk_deps.dart`.

benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/e59f675..a62e416):
  a62e416  2023-12-14  Kevin Moore  Require Dart 3.2, pub dependencies, cleanup analysis_options (#97)

cli_util (https://github.com/dart-lang/cli_util/compare/500dffa..e5b38ac):
  e5b38ac  2024-01-01  dependabot[bot]  Bump actions/stale from 8.0.0 to 9.0.0 (#96)
  91540ca  2023-12-20  Kevin Moore  blast_repo fixes (#95)
  1fd87c1  2023-12-15  Devon Carew  require dart 3.0; rev to 0.4.1 in prep for publishing (#93)

convert (https://github.com/dart-lang/convert/compare/3503170..f8a72d6):
  f8a72d6  2024-01-01  dependabot[bot]  Bump actions/stale from 8.0.0 to 9.0.0 (#98)
  e6b0558  2023-12-18  Kevin Moore  Enable and fix new lints (#97)
  39e5ca6  2023-12-18  Kevin Moore  blast_repo fixes (#96)

crypto (https://github.com/dart-lang/crypto/compare/f3e64d2..63e9a90):
  63e9a90  2024-01-01  dependabot[bot]  Bump actions/stale from 8.0.0 to 9.0.0 (#160)
  f2c79ed  2023-12-19  Kevin Moore  blast_repo fixes (#157)

csslib (https://github.com/dart-lang/csslib/compare/17346e5..1ad2d1e):
  1ad2d1e  2024-01-01  dependabot[bot]  Bump actions/stale from 8.0.0 to 9.0.0 (#195)
  1325d75  2023-12-18  Kevin Moore  blast_repo fixes (#193)

ecosystem (https://github.com/dart-lang/ecosystem/compare/ce707fb..dc44e82):
  dc44e82  2024-01-02  Moritz  Get needed version from API tool in health check (#213)
  55251b1  2024-01-02  Moritz  De-async health checks (#208)
  2587855  2024-01-01  dependabot[bot]  Bump peter-evans/create-or-update-comment (#211)
  0136c56  2024-01-01  dependabot[bot]  Bump actions/upload-artifact from 3.1.3 to 4.0.0 (#210)
  82f4b77  2024-01-01  dependabot[bot]  Bump actions/stale from 8.0.0 to 9.0.0 (#212)
  5e12e96  2024-01-01  dependabot[bot]  Bump actions/labeler from 4.3.0 to 5.0.0 (#209)
  5d594f4  2023-12-14  Kevin Moore  Require/support latest pkg:http (#207)
  b8679da  2023-12-07  Devon Carew  normalize sort order of package listing (#205)

json_rpc_2 (https://github.com/dart-lang/json_rpc_2/compare/460545c..ac1fabd):
  ac1fabd  2024-01-01  dependabot[bot]  Bump actions/stale from 8.0.0 to 9.0.0 (#108)

Change-Id: I83fa7042ac1970ae792110093bdcf8c0ec779fda
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/344260
Auto-Submit: Devon Carew <devoncarew@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgjesse sgjesse

Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. closed-duplicate Closed in favor of an existing report
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sgjesse @madsager @DartBot