Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utils/tests/css/src should be moved to tests/utils/src/css #2253

Closed
peter-ahe-google opened this issue Mar 22, 2012 · 2 comments
Closed

utils/tests/css/src should be moved to tests/utils/src/css #2253

peter-ahe-google opened this issue Mar 22, 2012 · 2 comments
Assignees
@terrylucas
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test).

Comments

@peter-ahe-google
Copy link
Contributor

I think the utils/tests/css tests are in the wrong location. Please consider moving them to tests/utils/src or tests/utils/src/css.
@ricowind
Copy link
Contributor

Terry, could we move these tests

Additionally, the status file is a bunch of skips, why are we skipping this all over?

@peter-ahe-google peter-ahe-google added Type-Defect area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). labels Nov 15, 2013
@srawlins
Copy link
Member

These were deleted in d5257a2.

@kevmoo kevmoo removed the triaged label Mar 1, 2016
dart-bot pushed a commit that referenced this issue Nov 11, 2019
@sigurdm
Upgrade pub revision
0e9eadc 
$ git log --pretty=oneline 80ac76400ff58fde3c5a335d860d196c3febe837..HEAD
d15067931a6b671a1c9dcc98b5923347676269cf Add link to Flutter plugin docs to warning message (#2253)
61601357ac5857ddf7507ef71678cb9d15344f26 Improve error message when .dart_tool/package_config.json is missing (#2252)

Change-Id: I01726a0dd3d1c96301425d97294c7251ed4681fc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124685
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@terrylucas terrylucas

Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kevmoo @srawlins @terrylucas @ricowind @peter-ahe-google