Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When using dart:html, on.change is not called if you change a select using code #2325

Closed
DartBot opened this issue Mar 27, 2012 · 11 comments
Closed

When using dart:html, on.change is not called if you change a select using code #2325

DartBot opened this issue Mar 27, 2012 · 11 comments
Labels
closed-as-intended Closed as the reported issue is expected behavior web-libraries Issues impacting dart:html, etc., libraries

Comments

@DartBot
Copy link

DartBot commented Mar 27, 2012

This issue was originally filed by jjinux...@google.com

When I used dart:dom, change events would occur whether it was the user changing the HTML element or whether I changed it with code. When I switched to dart:html, I found out that this was no longer true. This caused a bug in my code because I was expecting the change event to occur, and it didn't.

What steps will reproduce the problem?

  1. Try running the attached version of Tetris.
  2. If you change the level select, it'll generate an alert.
  3. Change it to level 10 and hit start.
  4. Wait until it says "Game over!".
  5. It'll programmatically reset the level to 1. However, it won't generate an on.change event. Hence, it won't generate a window.alert.

What is the expected output?
Whether I change the value of the HTML select with my mouse or via code, it should still generate an on.change event.

What do you see instead?
It only generates an event when I use my mouse.

What version of the product are you using?
I'm using the latest unstable version of the editor:
Version 0.1.0.201203271110, Build 5891
Dart SDK version 5891

On what operating system?
OS X 10.6

Please provide any additional information below:
I'm using Dartium.

Attachment:
src.tar.gz (33.88 KB)
@anders-sandholm
Copy link
Contributor

Added Area-IO, Triaged labels.

@madsager
Copy link
Contributor

Removed Area-IO label.
Added Area-UI label.

@vsmenon
Copy link
Member

vsmenon commented Apr 13, 2012

Removed Area-UI label.
Added Area-DOM label.

@vsmenon
Copy link
Member

vsmenon commented Jul 12, 2012

Added this to the M1 milestone.

@iposva-google
Copy link
Contributor

Removed Area-DOM label.
Added Area-HTML label.

@vsmenon
Copy link
Member

vsmenon commented Aug 23, 2012

Removed Area-HTML label.
Added Area-Dartium label.

@DartBot
Copy link
Author

DartBot commented Aug 24, 2012

This comment was originally written by antonm@google.com

Set owner to antonm@google.com.

@DartBot
Copy link
Author

DartBot commented Aug 28, 2012

This comment was originally written by antonm@google.com

This is about the code compiled to JS with dart2js, so it's not a Dartium issue.

cc @rakudrama.
cc @vsmenon.
Removed the owner.
Removed Area-Dartium label.
Added Area-HTML label.

@vsmenon
Copy link
Member

vsmenon commented Sep 5, 2012

Removed this from the M1 milestone.
Added this to the M2 milestone.

@blois
Copy link
Contributor

blois commented Oct 15, 2012

Removed this from the M2 milestone.
Added this to the Later milestone.

@efortuna
Copy link
Contributor

Added AsDesigned label.

@DartBot DartBot added Type-Defect web-libraries Issues impacting dart:html, etc., libraries closed-as-intended Closed as the reported issue is expected behavior labels Aug 26, 2013
@DartBot DartBot added this to the Later milestone Aug 26, 2013
dart-bot pushed a commit that referenced this issue Aug 11, 2020
@sigurdm
Bump pub version
4b3db02 
> git log --oneline 04b054b62cc437cf23451785fdc50e49cd9de139..master
0d185a39 (HEAD -> master, origin/master, origin/HEAD) Push null-safety forwards to 2.11 (#2604)
56f9f27f Hide outdated --mode flag (#2603)
61ce6f81 Avoid double loop (#2605)
fa6e57d7 (disable_mixed_mode_validation) Fix outdated latest ordering (#2598)
6549e4aa Remove unused dependency from pubspec.yaml (#2592)
61543d07 Don't look for external package foo during testing (#2599)
590b448f Fixed license headers (#2595)
04e0601e Don't show entries for dev-dependencies in outdated --json --no-dev-dependencies (#2591)
8c3778c4 Configure GitHub move app (#2578)
eec7beca (top_level_command) Pass --(no-)sound-null-safety arg through to VM. (#2542)
152e4740 Warn about publishing in mixed mode (#2583)
0b7a3abe Removed april fools toys (#2325)
b74a5b73 Actually print hints (#2582)
8ec3a66d (pub2) Fix outdated --no-color (#2572)
7bb3d4e6 Use getSdkPath() in NullSafetyAnalysis (#2573)
3c578f24 Drop the "magic" package concept (#2577)
0e967ff0 Remove unused function (#2570)
988fefef Remove dependency overrides (#2568)

Change-Id: I58bf14234ed55bf9d825de60a40ded1d65281195
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/158003
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-as-intended Closed as the reported issue is expected behavior web-libraries Issues impacting dart:html, etc., libraries
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@efortuna @vsmenon @blois @madsager @anders-sandholm @iposva-google @DartBot