Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dump info is inaccurate and incomplete #24095

Open
1 of 3 tasks
sigmundch opened this issue Aug 15, 2015 · 1 comment
Open
1 of 3 tasks

dump info is inaccurate and incomplete #24095

sigmundch opened this issue Aug 15, 2015 · 1 comment
Assignees
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-dart2js

Comments

@sigmundch
Copy link
Member

ensure that when we tally every element in the output of dumpinfo, we can count 100% of the program size.

We've seen that for small apps, 10% is missing, it might be more for larger apps. So far pieces that are not included are:

  • constants (fixed)
  • lazily initialized top-levels and statics
  • some portion of the dart2js setup boilerplate
@sigmundch sigmundch self-assigned this Aug 15, 2015
@sigmundch sigmundch changed the title dump info is not complete dump info is inaccurate and incomplete Aug 19, 2015
@sigmundch
Copy link
Member Author

Also, I've noticed some things might be counted twice, some things might be counted incorrectly.

Two examples I've noticed:

  • counting code, when size was previously registered. See dump_info L126 - maybe that add operation should be guarded with if size != 0?
  • adding more code than needed? In particular, dumpInfoTask.codeOf includes all code associated with an element. Are all those pieces present in the output and, thus, need to be counted?

@kevmoo kevmoo added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed Type-Defect labels Mar 1, 2016
@vsmenon vsmenon added the area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. label Jul 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-dart2js
Projects
None yet
Development

No branches or pull requests

3 participants