Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing legacy debug protocol from VM #24209

Closed
sethladd opened this issue Aug 26, 2015 · 11 comments
Closed

Removing legacy debug protocol from VM #24209

sethladd opened this issue Aug 26, 2015 · 11 comments
Assignees
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends.
Milestone

Comments

@sethladd
Copy link
Contributor

The Dart VM Service Protocol is now spec'ed and battle tested.

The legacy debug protocol is now deprecated. We intend to remove this support in 1.13. We encourage tool vendors to use the new Service Protocol for debugging a Dart VM.

@sethladd sethladd added the area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. label Aug 26, 2015
@sethladd sethladd added this to the 1.13 milestone Aug 26, 2015
@sethladd
Copy link
Contributor Author

cc @johnmccutchan @turnidge

@mit-mit
Copy link
Member

mit-mit commented Sep 17, 2015

@sethladd , should we move this bug to 1.14? This wont happen until then, right?

@sethladd sethladd modified the milestones: 1.14, 1.13 Sep 17, 2015
@mit-mit
Copy link
Member

mit-mit commented Nov 19, 2015

@iposva-google moving to you now that we are in 1.14.

@rmacnak-google
Copy link
Contributor

6249c2b

@zoechi
Copy link
Contributor

zoechi commented Dec 4, 2015

Is WebStorm using the new protocol already or will WebStorm debugging break with bleeding_edge in a few days @alexander-doroshko?

@alexander-doroshko
Copy link

WebStorm already uses new VM Service protocol for debugging in case of SDK 1.14+

@zoechi
Copy link
Contributor

zoechi commented Dec 7, 2015

@alexander-doroshko Great! Thanks for the confirmation.

@EasonPai
Copy link

EasonPai commented Mar 9, 2016

dear @alexander-doroshko,
how can I know my version of WebStorm is already uses new VM Service protocol for debugging?
I have an issue probably related to this.

When I tried to work on my Mac (El Captain) & WebStorm 10.0.4 , and I got the problem below.
If this is an issues related to the new protocol, what should i do now?

Unable to connect debugger to the Dart VM: Connection refused

/Users/eason/Documents/dev/dart/sdk/dart-sdk/dart-sdk_v1.14.2/bin/dart --ignore-unrecognized-flags --checked --package-root=/Users/eason/Documents/dev/dart/project/project-dartsphere/dartsphere/packages --debug:52304 --break-at-isolate-spawn --enable-vm-service:52305 --trace_service_pause_events /Users/eason/Documents/dev/dart/project/project-dartsphere/dartsphere/bin/main.dart
Observatory listening on http://127.0.0.1:52305
Process finished with exit code 137

@alexander-doroshko
Copy link

@EasonPai New VM Service Protocol is used for debugging if 2 conditions are met:

  • WebStorm 11+ or IntelliJ IDEA 15+
  • Dart SDK 1.14+

To make sure that VM Service Protocol is used for debugging see Dart VM command line: there should be no --debug:XXXX flag. In your case it is there and it confirms that you need to update your IDE.

@EasonPai
Copy link

Thanks for the info.
But it is frustrating that we can't use the version that we already bought to do the development.
Hope there will be some plugin or patch to help on this.

@alexander-doroshko
Copy link

@EasonPai WebStorm 10 was released on March 31, 2015. Dart SDK 1.14 was released 10 months later, on 29 of January, 2016. At that moment WebStorm 11 was already out and was already able to debug via new protocol. You shouldn't expect old IDE to support new technologies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends.
Projects
None yet
Development

No branches or pull requests

7 participants