-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
map_literal_oom_test fails on content shell in checked mode #24571
Comments
BUG=#24571 R=sgjesse@google.com Review URL: https://codereview.chromium.org/1406503002 .
This test has started passing again on all platforms except x64, where it is still failing. Status is updated in tests/standalone/standalone.status. The list of commits that seems to include the change that fixed it on most platforms is: Change #42752 Changed by hausner@google.com Token stream iterator improvement BUG= Review URL: https://codereview.chromium.org/1427863002 . runtime/vm/object.cc Changed by kevmoo@google.com Remove dart:isolate changes from 1.13 changelog, documented spawnUri environment argument Review URL: https://codereview.chromium.org/1423323003 . CHANGELOG.md Changed by terry@google.com Fixed Native custom element Review URL: https://codereview.chromium.org/1422323006 . sdk/lib/html/dartium/html_dartium.dart Changed by scheglov@google.com Fix for duplicate priority sources. Review URL: https://codereview.chromium.org/1408163008 . pkg/analysis_server/lib/src/analysis_server.dart Changed by jacobr@google.com Support isExternal method on MethodMirror in the Dart VM. Not really intended for public consumption. switch to using isExternal and using anonymous. Review URL: https://codereview.chromium.org/1421133003 . runtime/lib/mirrors.cc Changed by jacobr@google.com Add @anonymous annotation and restrict object literal constructors to only anonymous classes. This frees up defining factory constructors that do not correspond to object literals on JS interop classes. Review URL: https://codereview.chromium.org/1409033005 . pkg/compiler/lib/src/diagnostics/messages.dart |
BUG=#24795 BUG=#24571 R=sgjesse@google.com Review URL: https://codereview.chromium.org/1407113009 .
@alan-knight I suggest it is probably the commit to dartium in https://codereview.chromium.org/1490763005 The full blamelist for the run where it started again is: Changed by asgerf@google.com dart2js cps: Add more constraint rules to bounds-check elimination. Also added rules for ~/, %, >>, &, and unary negation operators. BUG= Review URL: https://codereview.chromium.org/1479193002 . pkg/compiler/lib/src/cps_ir/bounds_checker.dart Changed by hausner@google.com Eliminate all but one top-level class per library. This CL eliminates all TL classes but one per library. All TL functions and fields in the library are stored in that TL class. Because scripts are not stored directly in functions and fields, but are a After: Review URL: https://codereview.chromium.org/1410383020 . runtime/lib/mirrors.cc Changed by fschneider@google.com VM: In CompileAll, don't iterate collected closures for every class BUG= Review URL: https://codereview.chromium.org/1491503003 . runtime/vm/compiler.cc Changed by alanknight@google.com Add the right type conversions for various postMessage methods Review URL: https://codereview.chromium.org/1490763005 . sdk/lib/html/dart2js/html_dart2js.dart Changed by zra@google.com Thread and Timeline fixes for Mojo. Also removes the setup of an unneeded StackZone from a Timeline API BUG= Review URL: https://codereview.chromium.org/1483113002 . runtime/vm/dart_api_impl.cc Changed by alanknight@google.com Suppress more flaky co19 tests due to spawn semantics changes Review URL: https://codereview.chromium.org/1490863002 . tests/co19/co19-dartium.status |
BUG=#24571 BUG=#25125 TBR=fschneider@google.com Review URL: https://codereview.chromium.org/1504003002 .
Currently either passes, crashes, or runtime errors on bots. Skipping in https://codereview.chromium.org/1797013002 |
Test is gone. |
The test standalone/map_literal_oom_test fails on content shell (drt) in checked mode. It passes on dartium, only failing on drt. Marking this as low priority, since other out-of-memory tests are just skipped on dartium and drt, and the problem is probably just in what the test expects. The error is
FAILED: none-drt-checked release_x64 standalone/map_literal_oom_test
Expected: Pass
Actual: RuntimeError
CommandOutput[content_shell]:
stdout:
READY
Observatory listening on http://127.0.0.1:40817
CONSOLE MESSAGE: line 78: {
"type": "debug",
"value": "test_controller.js started",
"timestamp": 0
}
CONSOLE MESSAGE: line 78: {
"type": "window_onerror",
"value": "window.onerror called: \n\nhttp://127.0.0.1:58502/root_build/generated_tests/none-drt-checked/tests_standalone_map_literal_oom_test/test.dart:0:\nException: Out of Memory\n\n",
"timestamp": 0.369
}
CONSOLE ERROR: Exception: Out of Memory
CONSOLE INFO: Observatory listening at http://127.0.0.1:40817/
CONSOLE MESSAGE: line 78: {
"type": "window_onerror",
"value": "window.onerror called: \n\nhttp://127.0.0.1:58502/root_build/generated_tests/none-drt-checked/tests_standalone_map_literal_oom_test/test.dart:0:\nInternal error: Dart_Invoke expects library argument 'target' to be loaded.\n\n",
"timestamp": 0.372
}
CONSOLE ERROR: Internal error: Dart_Invoke expects library argument 'target' to be loaded.
Content-Type: text/plain
Running /mnt/data/b/build/slave/dartium-lucid64-full-be/build/src/dart/tests/standalone/map_literal_oom_test.dart
FAIL
FAIL
EOF
EOF
stderr:
[795:795:1012/220941:11609714889:ERROR:browser_main_loop.cc(163)] Running without the SUID sandbox! See https://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment for more information on developing with the sandbox on.
[868:868:1012/220941:11609980938:ERROR:renderer_main.cc(207)] Running without renderer sandbox
Exhausted heap space, trying to allocate 262512 bytes.
EOF
The text was updated successfully, but these errors were encountered: