-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Analyzer >= 0.26.1+15 breaks reflectable #24890
Comments
Reflectable too, see dart-archive/code_transformers#29, and Polymer, see #24735. |
@bwilkerson Any updates on this? I have a work-around – should that be what @eernstg is using, too? |
I'm confused. Does this bug still manifest after moving to analyzer version 0.27.0? I thought that fixed the problem. |
@bwilkerson See this branch of source_gen https://github.com/dart-lang/source_gen/tree/brian_weird_fix Removed the work around – many tests start to fail |
Hi, I've made several attempts to use a newer version of the analyzer (the On Thu, Dec 10, 2015 at 10:23 PM, Kevin Moore notifications@github.com
Erik Ernst - Google Danmark ApS |
I've validated the fix with |
In support of this: |
I've been having problems in dogma_codegen with 0.27.1+1 where Putting the pubspec at 0.27.1 works but 0.27.1+1 fails. |
Yes, 0.27.1+1 also breaks reflectable (the nulls from |
|
@eernstg is there a separate bug? Seemed similar to this issue. |
The issue google/reflectable.dart#54 tracks the |
@donny-dont @eernstg have you tried analyzer 0.27.1+2 + |
Hi, yes, we tried that, and it has the same issue (constants not resolved, On Wed, Jan 13, 2016 at 11:59 PM, Kevin Moore notifications@github.com
Erik Ernst - Google Danmark ApS |
Updated the title to "reflect" reflectable |
@bwilkerson this is tagged P1 but I don't see any updates for more than a month. What is the status here!? |
To be precise the title should indicate that there is one recent version that does not break reflectable, namely 0.27.1 (which is the one that we have been using ). E.g., 'Analyzer >0.27.1 breaks reflectable' might do. But I'm not sure it makes sense to change the title of an existing issue several times (it's difficult to understand the history when it does not match the title any more). There is also the issue google/reflectable.dart#54 which is directly concerned with the situation as seen from reflectable. I just confirmed that we still get null when evaluating many constants. The symptom as of today is that we get a message in the following format for every entry point being transformed:
Given that resolution is no longer completed on the |
The changes could affect |
Actually, every element knows the context in which it was created, so, given the
|
Clearing out 1.15 milestone as the last full push to dev has happened. If any changes are required before 1.15 is shipped, please file a merge request |
Wow, I've got something that works now! \o// |
https://codereview.chromium.org/1761423002/ uses lazy and fine-grained constant resolution based on |
Addressed by google/reflectable.dart@543ad76. |
See dart-lang/source_gen#67
The text was updated successfully, but these errors were encountered: