Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a notification to log (to clients) when server is resorting to pub list-dir. #24900

Closed
pq opened this issue Nov 12, 2015 · 7 comments
Closed

Add a notification to log (to clients) when server is resorting to pub list-dir. #24900

pq opened this issue Nov 12, 2015 · 7 comments
Assignees
@pq
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P1 A high priority bug; for example, a single project is unusable or has many test failures type-enhancement A request for a change that isn't a bug
Milestone
1.13

Comments

@pq
Copy link
Member

pq commented Nov 12, 2015

This should happen uncommonly (only for projects with no .packages file; which is to say pub get last run pre 1.12) but will be useful for forensics.
@pq pq added P1 A high priority bug; for example, a single project is unusable or has many test failures Type-Enhancement area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. labels Nov 12, 2015
@pq pq self-assigned this Nov 12, 2015
@pq pq added this to the 1.13 milestone Nov 12, 2015
@pq
Copy link
Member Author

pq commented Nov 12, 2015

An example of how this looks in Atom, using a server error notification.

screen shot 2015-11-12 at 10 53 13 am

@pq pq mentioned this issue Nov 12, 2015
Closed
@pq
Copy link
Member Author

pq commented Nov 12, 2015

Bug to track a more robust logging solution: #24901.

@pq
Copy link
Member Author

pq commented Nov 12, 2015

https://codereview.chromium.org/1438293002/

@jwren: could you patch this one-liner into IDEA and verify that we're getting notifications? (To trigger them, just delete .packages in a dart project.)

Thanks!

pq added a commit that referenced this issue Nov 12, 2015
@pq
Server notification to indicate pub list-dir fallback.
4680736 
For diagnostic purposes.

See: #24900 for more context.

BUG=24900
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1438293002 .
@pq pq mentioned this issue Nov 12, 2015
Closed
@pq
Copy link
Member Author

pq commented Nov 12, 2015

Request to merge: #24905.

@pq
Copy link
Member Author

pq commented Nov 12, 2015

OK, back-peddling.

Turns out this borks the integration tests (yay tests!)

The new approach is to add something to the status pages.

pq added a commit that referenced this issue Nov 12, 2015
@pq
Revert package logging (moving to status pages).
92fdffb 
Context:

#24900

BUG=24900
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1441673003 .
@pq
Copy link
Member Author

pq commented Nov 12, 2015

Here's how it might look on the main status page. Contexts that are missing .packages have an annotation (here for console-full).

screen shot 2015-11-12 at 2 40 55 pm

pq added a commit that referenced this issue Nov 12, 2015
@pq
Status page indicator for contexts w/o .packages.
eac5a0e 
For diagnostic purposes.

See: #24900 for more context.

BUG=24900
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1436343002 .
@pq
Copy link
Member Author

pq commented Nov 12, 2015

Implemented w/ eac5a0e.

Request to merge: #24905.

@pq pq closed this as completed Nov 12, 2015
pq added a commit that referenced this issue Nov 13, 2015
@pq @dgrove
Status page indicator for contexts w/o .packages.
c2a073e 
For diagnostic purposes.

See: #24900 for more context.

BUG=24900
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1436343002 .
@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed type-enhancement labels Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pq pq

Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P1 A high priority bug; for example, a single project is unusable or has many test failures type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
1.13
Development

No branches or pull requests
2 participants
@kevmoo @pq