Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

html/js_test/JsArray failing on all browsers #26197

Closed
whesse opened this issue Apr 6, 2016 · 1 comment
Closed

html/js_test/JsArray failing on all browsers #26197

whesse opened this issue Apr 6, 2016 · 1 comment
Assignees
@jacob314
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-libraries Issues impacting dart:html, etc., libraries

Comments

@whesse
Copy link
Contributor

whesse commented Apr 6, 2016

This test started failing on all browsers using dart2js after one of the following commits:

Change #45580

Changed by sigmund@google.com
Changed at Tue 29 Mar 2016 17:37:03
Repository https://chromium.googlesource.com/external/github.com/dart-lang/sdk.git
Project sdk-master
Branch master
Revision c5ae911
Comments

Update status on safari tests that started passing after the update.
BUG=

Review URL: https://codereview.chromium.org/1843883002 .
Changed files

tests/co19/co19-dart2js.status
tests/corelib/corelib.status
tests/html/html.status
tests/lib/lib.status
tests/try/try.status
Change #45581

Changed by fschneider@google.com
Changed at Tue 29 Mar 2016 17:40:58
Repository https://chromium.googlesource.com/external/github.com/dart-lang/sdk.git
Project sdk-master
Branch master
Revision 15f23ee
Comments

VM: Fix --no-use-field-guards.
Fields read from the snapshot must be initialized in the same way
as when allocated with Field::New.

BUG=#25957
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/1842853002 .
Changed files

runtime/vm/jit_optimizer.cc
runtime/vm/raw_object_snapshot.cc
tests/corelib/double_parse_test.dart
tests/corelib/num_sign_test.dart
tests/language/cha_deopt2_test.dart
tests/language/cha_deopt3_test.dart
Change #45582

Changed by rmacnak@google.com
Changed at Tue 29 Mar 2016 17:55:35
Repository https://chromium.googlesource.com/external/github.com/dart-lang/sdk.git
Project sdk-master
Branch master
Revision 64871bc
Comments

Mark the precompilation tests as slow.
TBR=srdjan@google.com

Review URL: https://codereview.chromium.org/1843513004 .
Changed files

tests/standalone/standalone.status
Change #45583

Changed by fschneider@google.com
Changed at Tue 29 Mar 2016 18:10:18
Repository https://chromium.googlesource.com/external/github.com/dart-lang/sdk.git
Project sdk-master
Branch master
Revision a91f758
Comments

VM: Fix incorrect debug assertion.
BUG=

Review URL: https://codereview.chromium.org/1840173003 .
Changed files

runtime/vm/jit_optimizer.cc
Change #45584

Changed by jacobr@google.com
Changed at Tue 29 Mar 2016 18:32:52
Repository https://chromium.googlesource.com/external/github.com/dart-lang/sdk.git
Project sdk-master
Branch master
Revision c65854d
Comments

Optimize dartium dart:html bindings so real world application performance is acceptable. Improves dart:html performance by 2X-30X for microbenchmarks. Real world improvement is typically 2X-3X.
BUG=

Review URL: https://codereview.chromium.org/1832713002 .
Changed files

sdk/lib/_blink/dartium/_blink_dartium.dart
sdk/lib/html/dart2js/html_dart2js.dart
sdk/lib/html/dartium/html_dartium.dart
sdk/lib/html/html_common/conversions_dart2js.dart
sdk/lib/html/html_common/conversions_dartium.dart
sdk/lib/indexed_db/dartium/indexed_db_dartium.dart
sdk/lib/js/dartium/cached_patches.dart
sdk/lib/js/dartium/js_dartium.dart
sdk/lib/svg/dartium/svg_dartium.dart
sdk/lib/web_audio/dartium/web_audio_dartium.dart
sdk/lib/web_gl/dartium/web_gl_dartium.dart
sdk/lib/web_sql/dartium/web_sql_dartium.dart
tests/co19/co19-analyzer2.status
tests/html/html.status
tests/html/js_array_test.dart
tests/html/js_test.dart
tests/html/wrapping_collections_test.dart
tools/deps/dartium.deps/DEPS
tools/dom/dom.json
tools/dom/scripts/css_code_generator.py
tools/dom/scripts/generate_blink_file.py
tools/dom/scripts/generator.py
tools/dom/scripts/htmldartgenerator.py
tools/dom/scripts/systemhtml.py
tools/dom/scripts/systemnative.py
tools/dom/src/dartium_CustomElementSupport.dart
tools/dom/src/dartium_KeyEvent.dart
tools/dom/src/dartium_WrappedEvent.dart
tools/dom/src/native_DOMImplementation.dart
tools/dom/templates/html/dart2js/html_dart2js.darttemplate
tools/dom/templates/html/dartium/html_dartium.darttemplate
tools/dom/templates/html/dartium/indexed_db_dartium.darttemplate
tools/dom/templates/html/dartium/svg_dartium.darttemplate
tools/dom/templates/html/dartium/web_audio_dartium.darttemplate
tools/dom/templates/html/dartium/web_gl_dartium.darttemplate
tools/dom/templates/html/dartium/web_sql_dartium.darttemplate
tools/dom/templates/html/impl/impl_Blob.darttemplate
tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate
tools/dom/templates/html/impl/impl_CustomEvent.darttemplate
tools/dom/templates/html/impl/impl_DataTransferItemList.darttemplate
tools/dom/templates/html/impl/impl_Document.darttemplate
tools/dom/templates/html/impl/impl_DocumentType.darttemplate
tools/dom/templates/html/impl/impl_Element.darttemplate
tools/dom/templates/html/impl/impl_FileReader.darttemplate
tools/dom/templates/html/impl/impl_HTMLAudioElement.darttemplate
tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate
tools/dom/templates/html/impl/impl_HTMLElement.darttemplate
tools/dom/templates/html/impl/impl_IDBDatabase.darttemplate
tools/dom/templates/html/impl/impl_MessageEvent.darttemplate
tools/dom/templates/html/impl/impl_MutationObserver.darttemplate
tools/dom/templates/html/impl/impl_Node.darttemplate
tools/dom/templates/html/impl/impl_SVGCursorElement.darttemplate
tools/dom/templates/html/impl/impl_SVGElement.darttemplate
tools/dom/templates/html/impl/impl_SVGFEDropShadowElement.darttemplate
tools/dom/templates/html/impl/impl_SVGGlyphRefElement.darttemplate
tools/dom/templates/html/impl/impl_SVGMPathElement.darttemplate
tools/dom/templates/html/impl/impl_ServiceWorkerMessageEvent.darttemplate
tools/dom/templates/html/impl/impl_Touch.darttemplate
tools/dom/templates/html/impl/impl_WheelEvent.darttemplate
tools/dom/templates/html/impl/impl_Window.darttemplate
tools/dom/templates/html/impl/impl_WorkerLocation.darttemplate
tools/dom/templates/html/impl/impl_WorkerNavigator.darttemplate
tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate
@whesse whesse added P1 A high priority bug; for example, a single project is unusable or has many test failures web-libraries Issues impacting dart:html, etc., libraries type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) labels Apr 6, 2016
whesse added a commit that referenced this issue Apr 6, 2016
@whesse
Update status for html/JsArray test, increase dart2js timeout on brow…
82e6256 
…ser bots.

BUG=#26060
BUG=#26197
R=kustermann@google.com

Review URL: https://codereview.chromium.org/1865913002 .
@sigmundch
Copy link
Member

/cc @jacob314 - seems likely related to your change?

@jacob314 jacob314 self-assigned this Apr 6, 2016
vsmenon pushed a commit that referenced this issue Jan 4, 2017
@jacob314 @vsmenon
Correct handling of cross-frame functions in ddc.
a65d637 
Misc fixes of dart:js support on ddc.
Work around issue with Blob constructor on ddc.
Fix incorrect dart:js test on dart2js (fixes #26197)

BUG=
R=alanknight@google.com, leafp@google.com, rnystrom@google.com

Review-Url: https://codereview.chromium.org/2587203002 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacob314 jacob314

Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-libraries Issues impacting dart:html, etc., libraries
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jacob314 @sigmundch @whesse