Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vm/cc tests of dart2js must use .packages instead of package root #27369

Closed
whesse opened this issue Sep 16, 2016 · 2 comments
Closed

vm/cc tests of dart2js must use .packages instead of package root #27369

whesse opened this issue Sep 16, 2016 · 2 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@whesse
Copy link
Contributor

whesse commented Sep 16, 2016

The vm cc tests use a shortcut to resolve packages in some of their tests, like vm/cc/Dart2JSCompileAll.

This needs to be fixed, and it looks like it may need async dart code to run. The tests will be marked as failing until then. I have a partial solution CL that loads and stores the .packages file, but using it to resolve URLs is a TODO.

The failing tests are
vm/cc/Dart2JSCompilerStats
vm/cc/Dart2JSCompileAll
@whesse whesse added area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) labels Sep 16, 2016
@whesse
Copy link
Contributor Author

whesse commented Sep 16, 2016

CL is https://codereview.chromium.org/2342323003

dart-bot pushed a commit that referenced this issue Jun 6, 2019
@a-siva
[VM/benchmarks] Rework Dart2JSCompileAll test to instead do CFE compi…
7e9a4b7 
…le all

The Dart2JSCompileAll test has not been working for a while due to
- issues with package config
- issues with getting the sources compiled with CFE after the switch to
  kernel pipeline.
Revised this benchmark/test to instead load the kernel_service dill file and do a CompileAll of CFE.

Should fix
#36630
#27369

Change-Id: I07f5c81fc6938d318b84fa9ea2fa033ec30a05e8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103406
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
@a-siva
Copy link
Contributor

a-siva commented Jun 10, 2019

The Dart2JSCompileAll benchmark has been reworded to use a dill file and does not need a way of resolving package root.

@a-siva a-siva closed this as completed Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@whesse @a-siva