Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frogc generated wrong JS code #2739

Closed
DartBot opened this issue Apr 26, 2012 · 4 comments
Closed

frogc generated wrong JS code #2739

DartBot opened this issue Apr 26, 2012 · 4 comments
Labels
closed-not-planned Closed as we don't intend to take action on the reported issue web-dart2js

Comments

@DartBot
Copy link

DartBot commented Apr 26, 2012

This issue was originally filed by @tomyeh


What steps will reproduce the problem?

  1. Compile the following code
    class C {
        Set<String> _classes;

    void run() {
        final StringBuffer out = new StringBuffer();
        if (_classes != null)
            for (final String cls in _classes) {
                out.add(' ').add(cls);
            }
    }
}
void main() {
    new C().run();
}

What is the expected output? What do you see instead?
frogc generated the wrong JS code:

  if (this._classes != null) var $$list = this._classes;
  for (var $$i = $$list.iterator(); $$i.hasNext(); ) {
    var cls = $$i.next();
    out.add(" ").add(cls);
  }

Obviously, a curly brace is missed to enclose var $$list...

@kasperl
Copy link

kasperl commented Apr 26, 2012

Added Area-Frog, Triaged labels.

@anders-sandholm
Copy link
Contributor

Removed Area-Frog label.
Added Area-Dart2JS, OldAreaFrog labels.

@anders-sandholm
Copy link
Contributor

Removed OldAreaFrog label.
Added FromAreaFrog label.

@kasperl
Copy link

kasperl commented Jun 12, 2012

Added WontFix label.

@kevmoo kevmoo added closed-not-planned Closed as we don't intend to take action on the reported issue and removed resolution-wont_fix labels Mar 1, 2016
dart-bot pushed a commit that referenced this issue Nov 12, 2020
New in this revision:

> git log --format="%C(auto) %h %s" b10966c6a8ad7d95c2023b7842fa2697001d2fdf..c00d4b4abf5b4ff265a7ce6282b748551f1b5b1f
 c00d4b4a Improve message in `pub outdated` when incompatible versions are found (#2746)
 2a177623 outdated --mode=null-safety, resolvable constrained to null-safe vers… (#2739)
 3ea2b832 Default language version (#2748)
 78865460 Don't allow both --json and --transitive (#2742)

Fixes #44013

Change-Id: I0dc876c5e57777a4724d90662408f91910e2517c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171720
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Reviewed-by: Michael Thomsen <mit@google.com>
dart-bot pushed a commit that referenced this issue Nov 13, 2020
New in this revision:

> git log --format="%C(auto) %h %s" b10966c6a8ad7d95c2023b7842fa2697001d2fdf..c00d4b4abf5b4ff265a7ce6282b748551f1b5b1f
 c00d4b4a Improve message in `pub outdated` when incompatible versions are found (#2746)
 2a177623 outdated --mode=null-safety, resolvable constrained to null-safe vers… (#2739)
 3ea2b832 Default language version (#2748)
 78865460 Don't allow both --json and --transitive (#2742)

Fixes #44013

Change-Id: I0dc876c5e57777a4724d90662408f91910e2517c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171720
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Reviewed-by: Michael Thomsen <mit@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-not-planned Closed as we don't intend to take action on the reported issue web-dart2js
Projects
None yet
Development

No branches or pull requests

4 participants