Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing new keyword #27443

Closed
nshahan opened this issue Sep 27, 2016 · 1 comment
Closed

Missing new keyword #27443

nshahan opened this issue Sep 27, 2016 · 1 comment
Assignees
Milestone

Comments

@nshahan
Copy link
Contributor

nshahan commented Sep 27, 2016

Missing a "new" keyword on an external constructor.

A call to:

@JS('Quill')
abstract class QuillStatic {
  external factory QuillStatic(String selector, [QuillOptionsStatic options]);
...
}
external QuillStatic get Quill;

produced the javasctip code:

main.bar = dart.global.Quill('#editor', {theme: 'snow', placeholder: main.prompt});
@Sfshaza Sfshaza added this to the 1.21 milestone Oct 5, 2016
@kevmoo
Copy link
Member

kevmoo commented Oct 6, 2016

Fix pending - https://codereview.chromium.org/2399593003/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants