Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vm/dart/hello_fuchsia_test fails on dartium #27867

Closed
whesse opened this issue Nov 21, 2016 · 3 comments
Closed

vm/dart/hello_fuchsia_test fails on dartium #27867

whesse opened this issue Nov 21, 2016 · 3 comments
Assignees
@zanderso
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@whesse
Copy link
Contributor

whesse commented Nov 21, 2016

The new test runtime/tests/vm/dart/hello_fuchsia_test.dart fails on dartium

Marking as fail in runtime/tests/vm/vm.status

@terrylucas @zanderso
@whesse whesse added area-dartium area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) labels Nov 21, 2016
whesse added a commit that referenced this issue Nov 21, 2016
@whesse
Update status for hello_fuchsia test on dartium.
dbf8d06 
BUG=#27867
R=sortie@google.com

Review URL: https://codereview.chromium.org/2517113003 .
@a-siva
Copy link
Contributor

a-siva commented Nov 21, 2016

Why is this test running on dartium? I will update the status file to skip this test.

@whesse
Copy link
Contributor Author

whesse commented Nov 21, 2016

Also skip it on dart2js - it is failing on the browsers. The vm tests should not be specific to a specific runtime. I don't think this is the place for this test - it should be in the tests/standalone directory, or if there are tests specific to the fuchsia embedding rather than the standalone embedding, then there should be a tests/standalone/fuchsia or tests/fuchsia directory.

@whesse
Copy link
Contributor Author

whesse commented Nov 22, 2016

I have a CL to skip it on dart2js, so I will close the issue when it is landed.

whesse added a commit that referenced this issue Nov 23, 2016
@whesse
Update status for Firefox 50
4bfe727 
BUG=#27873
BUG=#27872
BUG=#27871
BUG=#27867
R=sortie@google.com

Review URL: https://codereview.chromium.org/2526493004 .
a-siva added a commit that referenced this issue Nov 23, 2016
@a-siva
Skip Fuchsia test on non VM runtimes.
373aa19 
BUG=#27867

Review URL: https://codereview.chromium.org/2530613002 .
@a-siva a-siva closed this as completed Nov 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zanderso zanderso

Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@whesse @zanderso @a-siva