Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

comments are not always visually highlighed [+3] #2817

Closed
danrubel opened this issue Apr 30, 2012 · 10 comments
Closed

comments are not always visually highlighed [+3] #2817

danrubel opened this issue Apr 30, 2012 · 10 comments
Assignees
@stevemessick
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures
Milestone
M1

Comments

@danrubel
Copy link

[user feedback]
// comments are not always visually highlighed
////////////////////////////////////////////////////////////////////////////////////
Editor Version: 6943
@stevemessick
Copy link
Contributor

Added CannotReproduce label.

@clayberg
Copy link

clayberg commented May 7, 2012

[user feedback]

Issue #2817: comments are not always visually highlighed
closed as CannotReproduce
is actually very common (tested again in latest 7209 build) and an easy example is:

class TestComment {
 TestComment() {
 }
} // TestComment

move cursor to the constructor closing brace line and add / (or even a space) and the existing comment is now parsed with code formatting
Now remove the / or space - comment formatting does not recover (unless file is closed and reopened)
Now add // to the constructor opening brace line, formatting appears to recover
Now remove the //, the end comment is parsed with code formatting again.

Obviously 'real' examples appear subtly different, and harder to recreate.
I would only class this as minor, (but distracting)

////////////////////////////////////////////////////////////////////////////////////
Editor Version: 7209

@clayberg
Copy link

clayberg commented May 7, 2012

Added Triaged label.

@stevemessick
Copy link
Contributor

Issue #3158 has been merged into this issue.

@stevemessick
Copy link
Contributor

Added this to the M1 milestone.

@floitschG
Copy link
Contributor

Screenshot (from issue #4472).

Attachment:
syntax.png (9.96 KB)

@floitschG
Copy link
Contributor

Issue #4472 has been merged into this issue.

@danrubel
Copy link
Author

Removed Priority-Medium label.
Added Priority-High label.
Changed the title to: " comments are not always visually highlighed [+3]".

@danrubel
Copy link
Author

Issue #4471 has been merged into this issue.

@stevemessick
Copy link
Contributor

Added Fixed label.

@danrubel danrubel added Type-Defect P1 A high priority bug; for example, a single project is unusable or has many test failures labels Aug 13, 2012
@danrubel danrubel added this to the M1 milestone Aug 13, 2012
dart-bot pushed a commit that referenced this issue Mar 23, 2021
@sigurdm
Bump pub
633d4ac 
New commits included:
```
> git log --format="%C(auto) %h %s" 0e657414a472e74ca5dd76ae0db50cc060251dec..255a3091fc278b04be74d246a3bec8743ef4d0b7
 255a3091 Vendor package:tar and package:chunked_stream (#2932)
 86bf8b20 Handle relative git-url-paths correctly when --directory (#2919)
 3716a681 Let `pub add` fail if extra arguments are passed (#2927)
 a03ac729 Minor cleanup to reduce risk of using path.current (#2924)
 e87b7b66 Added null check for name in UserInfo class (#2918)
 056a8c9a pub deps --json (#2896)
 53a69e27 Fix .packages entries of relative path deps when using --directory (#2916)
 d6308efc pub upgrade command shows count of discontinued packages (#2908)
 51744805 Upgrade to the null safe versions of all dependencies (#2913)
 e0d538c7 Introduce .pubignore (#2787)
 79f3a8b9 pub outdated: added clear message when no outdated packages. (#2898)
 22463872 `cache clean` (#2904)
 11e7b2ce `publish --dry-run` informs that the server might do more checks (#2883)
 b6977d50 Remove untrue assert (#2884)
 35841f8d Merge branch 'cherry_picks_for_2_12'
 0db3255b Don't fail on failed status listing (#2877)
 53e8ecca Don't allow outdated taking arguments (#2872)
 e83a1dc1 Enable asserts when testing pub (#2754)
 178f2edb Add --directory option (#2876)
 5aadb70e Don't fail on failed status listing (#2877)
 4bf8a927 Remove unused field (#2878)
 73ad5426 Don't allow outdated taking arguments (#2872)
 9a70949e Use Dart library to read and write tar files (#2817)
 2f74230c Do not recommend decativating packages (#2871)
 b1697a27 Use full error message string in CommandResolutionFailedException (#2870)
 16a6210d Upgrade `downgrade --help`: `downgrade` actually updates `pubspec.lock` (#2859)
 6e240ea9 Use cached version listings as heuristic when prefetching (#2851)
 58152f7c Allow trailing slash in PUB_HOSTED_URL (#2856)
 b1bf9a33 Handle poor package-listing responses robustly. (#2847)
 d941bd24 Fix request metadata when overriding dependencyType (#2848)
 ```

Change-Id: Id6ed5698330fc0cdb507e024eabc34f925ca9208
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192304
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
Reviewed-by: Jonas Jensen <jonasfj@google.com>
dart-bot pushed a commit that referenced this issue Mar 24, 2021
@athomas
Revert "Bump pub"
424c554 
This reverts commit 633d4ac.

Reason for revert: breaks dependency resolution in some cases.

Original change's description:
> Bump pub
>
> New commits included:
> ```
> > git log --format="%C(auto) %h %s" 0e657414a472e74ca5dd76ae0db50cc060251dec..255a3091fc278b04be74d246a3bec8743ef4d0b7
>  255a3091 Vendor package:tar and package:chunked_stream (#2932)
>  86bf8b20 Handle relative git-url-paths correctly when --directory (#2919)
>  3716a681 Let `pub add` fail if extra arguments are passed (#2927)
>  a03ac729 Minor cleanup to reduce risk of using path.current (#2924)
>  e87b7b66 Added null check for name in UserInfo class (#2918)
>  056a8c9a pub deps --json (#2896)
>  53a69e27 Fix .packages entries of relative path deps when using --directory (#2916)
>  d6308efc pub upgrade command shows count of discontinued packages (#2908)
>  51744805 Upgrade to the null safe versions of all dependencies (#2913)
>  e0d538c7 Introduce .pubignore (#2787)
>  79f3a8b9 pub outdated: added clear message when no outdated packages. (#2898)
>  22463872 `cache clean` (#2904)
>  11e7b2ce `publish --dry-run` informs that the server might do more checks (#2883)
>  b6977d50 Remove untrue assert (#2884)
>  35841f8d Merge branch 'cherry_picks_for_2_12'
>  0db3255b Don't fail on failed status listing (#2877)
>  53e8ecca Don't allow outdated taking arguments (#2872)
>  e83a1dc1 Enable asserts when testing pub (#2754)
>  178f2edb Add --directory option (#2876)
>  5aadb70e Don't fail on failed status listing (#2877)
>  4bf8a927 Remove unused field (#2878)
>  73ad5426 Don't allow outdated taking arguments (#2872)
>  9a70949e Use Dart library to read and write tar files (#2817)
>  2f74230c Do not recommend decativating packages (#2871)
>  b1697a27 Use full error message string in CommandResolutionFailedException (#2870)
>  16a6210d Upgrade `downgrade --help`: `downgrade` actually updates `pubspec.lock` (#2859)
>  6e240ea9 Use cached version listings as heuristic when prefetching (#2851)
>  58152f7c Allow trailing slash in PUB_HOSTED_URL (#2856)
>  b1bf9a33 Handle poor package-listing responses robustly. (#2847)
>  d941bd24 Fix request metadata when overriding dependencyType (#2848)
>  ```
>
> Change-Id: Id6ed5698330fc0cdb507e024eabc34f925ca9208
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192304
> Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
> Reviewed-by: Jonas Jensen <jonasfj@google.com>

TBR=sigurdm@google.com,jonasfj@google.com

Change-Id: I364a26468a36438bbbc887e613241030decef4d3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192748
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
dart-bot pushed a commit that referenced this issue May 11, 2021
@jonasfj
Bump pub
53448de 
New commits include:
```
$ git log --format="%C(auto) %h %s" 0e657414a472e74ca5dd76ae0db50cc060251dec..00c00e8adf9706bebe8f94483b7663c5f36f59d2
 00c00e8a Vendor tar (#2987)
 291705ca Being gradual migration to null-safety (#2988)
 c5f52a37 Fix CI (#2989)
 74040a45 Update to analyzer 1.5.0, migrate from deprecated AnalysisSession.getParsedUnit() (#2975)
 ce951d70 Fix dry-run tests for publishing  by ensuring there is a server to reject requests (#2978)
 018c9650 Update LICENSE (#2944)
 2614f15c Revert "Vendor package:tar and package:chunked_stream (#2932)" (#2940)
 12d9f457 Handle package:tar cancellations
 255a3091 Vendor package:tar and package:chunked_stream (#2932)
 86bf8b20 Handle relative git-url-paths correctly when --directory (#2919)
 3716a681 Let `pub add` fail if extra arguments are passed (#2927)
 a03ac729 Minor cleanup to reduce risk of using path.current (#2924)
 e87b7b66 Added null check for name in UserInfo class (#2918)
 056a8c9a pub deps --json (#2896)
 53a69e27 Fix .packages entries of relative path deps when using --directory (#2916)
 d6308efc pub upgrade command shows count of discontinued packages (#2908)
 51744805 Upgrade to the null safe versions of all dependencies (#2913)
 e0d538c7 Introduce .pubignore (#2787)
 79f3a8b9 pub outdated: added clear message when no outdated packages. (#2898)
 22463872 `cache clean` (#2904)
 11e7b2ce `publish --dry-run` informs that the server might do more checks (#2883)
 b6977d50 Remove untrue assert (#2884)
 35841f8d Merge branch 'cherry_picks_for_2_12'
 0db3255b Don't fail on failed status listing (#2877)
 53e8ecca Don't allow outdated taking arguments (#2872)
 e83a1dc1 Enable asserts when testing pub (#2754)
 178f2edb Add --directory option (#2876)
 5aadb70e Don't fail on failed status listing (#2877)
 4bf8a927 Remove unused field (#2878)
 73ad5426 Don't allow outdated taking arguments (#2872)
 9a70949e Use Dart library to read and write tar files (#2817)
 2f74230c Do not recommend decativating packages (#2871)
 b1697a27 Use full error message string in CommandResolutionFailedException (#2870)
 16a6210d Upgrade `downgrade --help`: `downgrade` actually updates `pubspec.lock` (#2859)
 6e240ea9 Use cached version listings as heuristic when prefetching (#2851)
 58152f7c Allow trailing slash in PUB_HOSTED_URL (#2856)
 b1bf9a33 Handle poor package-listing responses robustly. (#2847)
 d941bd24 Fix request metadata when overriding dependencyType (#2848)
```

Change-Id: Id7cc4c09e74c02a92bcafe1a9d9bab9431900540
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/199040
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Jonas Jensen <jonasfj@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevemessick stevemessick

Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Milestone
M1
Development

No branches or pull requests
4 participants
@danrubel @stevemessick @clayberg @floitschG