Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Local functions with named arguments do not work. #282

Closed
rakudrama opened this issue Nov 1, 2011 · 6 comments
Closed

Local functions with named arguments do not work. #282

rakudrama opened this issue Nov 1, 2011 · 6 comments
Labels
closed-not-planned Closed as we don't intend to take action on the reported issue web-dart2js

Comments

@rakudrama
Copy link
Member

For a repro, revert dart/client/dom/scripts/idlparser.dart to r985
(i.e. before this work-around https://code.google.com/p/dart/source/detail?r=986 )
@jmesserly
Copy link

yeah, this is sadly not yet implemented. We need a better way to encode the optional argument info, such that it doesn't cost anything if you aren't using the optional args. (Probably in the name, fwiw)

@jmesserly
Copy link

Marked this as blocking #854.

@jmesserly
Copy link

The fix for this should also fix this issue: http://code.google.com/p/dart/issues/detail?id=854

@sigmundch
Copy link
Member

Unmarked this as blocking #-854.

@anders-sandholm
Copy link
Contributor

Removed Area-Frog label.
Added Area-Dart2JS, FromAreaFrog labels.

@kasperl
Copy link

kasperl commented Jun 8, 2012

Added WontFix label.

@kevmoo kevmoo added closed-not-planned Closed as we don't intend to take action on the reported issue and removed resolution-wont_fix labels Mar 1, 2016
pq added a commit that referenced this issue Aug 15, 2016
@pq
Update to DEPS to linter 0.1.24.
e5029df 
Picks up:

* Internal updates to keep up with changes in the analyzer package.
* Updated `close_sinks` to respect calls to `destroy` (#282).
* Fixed `only_throw_errors` to report on the expression not node.

BUG=
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/2247793002 .
@MananKakadiya MananKakadiya mentioned this issue Sep 25, 2018
Closed
This was referenced Oct 29, 2020
Open
Closed
Closed
This was referenced Nov 5, 2020
Closed
Open
copybara-service bot pushed a commit that referenced this issue May 9, 2023
@devoncarew
[deps] rev async, benchmark_harness, boolean_selector, clock, collect…
760ab0f 
…ion, convert, crypto, csslib, ffi, fixnum, glob, html, http_multi_server, http_parser, json_rpc_2, logging, mime, package_config, pool, pub_semver, source_map_stack_trace, sse, stack_trace, stream_channel, string_scanner, term_glyph, test_descriptor, tools, typed_data, web_socket_channel, webdev, yaml, yaml_edit

Revisions updated by `dart tools/rev_sdk_deps.dart`.

async (https://github.com/dart-lang/async/compare/b9ed219..0f368d3):
  0f368d3  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#240)

benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/e591ec4..f81b042):
  f81b042  2023-05-08  Devon Carew  Update pubspec.yaml (#89)
  1dc07da  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#88)

boolean_selector (https://github.com/dart-lang/boolean_selector/compare/9fd3bae..7eed402):
  7eed402  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#46)

clock (https://github.com/dart-lang/clock/compare/6b2004c..6b9df3e):
  6b9df3e  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#50)

collection (https://github.com/dart-lang/collection/compare/bf27520..6abff47):
  6abff47  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#282)

convert (https://github.com/dart-lang/convert/compare/855aeac..b652c00):
  b652c00  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#82)

crypto (https://github.com/dart-lang/crypto/compare/c5403c8..4e9dde1):
  4e9dde1  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#147)

csslib (https://github.com/dart-lang/csslib/compare/44bfbe3..923edf0):
  923edf0  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#178)

ffi (https://github.com/dart-lang/ffi/compare/6d8fa8d..1a859e0):
  1a859e0  2023-05-09  Michael Thomsen  Add topics in pubspec.yaml (#192)

fixnum (https://github.com/dart-lang/fixnum/compare/92ec336..006a130):
  006a130  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#111)

glob (https://github.com/dart-lang/glob/compare/eaa878b..46403be):
  46403be  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#76)

html (https://github.com/dart-lang/html/compare/5d87dc8..593d6f6):
  593d6f6  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#214)

http_multi_server (https://github.com/dart-lang/http_multi_server/compare/e0b5d35..d1fffed):
  d1fffed  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#54)

http_parser (https://github.com/dart-lang/http_parser/compare/bbe37dd..5a33f5f):
  5a33f5f  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#72)

json_rpc_2 (https://github.com/dart-lang/json_rpc_2/compare/5da2705..800843e):
  800843e  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#96)

logging (https://github.com/dart-lang/logging/compare/787030a..4779d7e):
  4779d7e  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#136)

mime (https://github.com/dart-lang/mime/compare/2d8496d..cd8001e):
  cd8001e  2023-05-09  Lara Schütt  Add `text/markdown` mimeType lookup by extension (#85)
  a0ea506  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#93)

package_config (https://github.com/dart-lang/package_config/compare/7e09db1..f41f92c):
  f41f92c  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#134)

pool (https://github.com/dart-lang/pool/compare/650e5d3..86b4f43):
  86b4f43  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#68)

pub_semver (https://github.com/dart-lang/pub_semver/compare/c3e56d1..6dd1908):
  6dd1908  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#85)

source_map_stack_trace (https://github.com/dart-lang/source_map_stack_trace/compare/08a81a8..09715f9):
  09715f9  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#38)

sse (https://github.com/dart-lang/sse/compare/f947c3d..11ba89e):
  11ba89e  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#83)

stack_trace (https://github.com/dart-lang/stack_trace/compare/9c1b1c5..36fa0e1):
  36fa0e1  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#130)

stream_channel (https://github.com/dart-lang/stream_channel/compare/71d4690..a862e41):
  a862e41  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#90)

string_scanner (https://github.com/dart-lang/string_scanner/compare/f7a656f..3bc6e54):
  3bc6e54  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#57)

term_glyph (https://github.com/dart-lang/term_glyph/compare/b110501..3de5f1b):
  3de5f1b  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#37)

test_descriptor (https://github.com/dart-lang/test_descriptor/compare/aa11162..23e49a2):
  23e49a2  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#51)

tools (https://github.com/dart-lang/tools/compare/6c68bca..62c9604):
  62c9604  2023-05-08  dependabot[bot]  Bump coverallsapp/github-action from 2.0.0 to 2.1.2 (#88)
  fde75bf  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#89)

typed_data (https://github.com/dart-lang/typed_data/compare/d85363d..021f25a):
  021f25a  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#64)

web_socket_channel (https://github.com/dart-lang/web_socket_channel/compare/b28bae6..2630714):
  2630714  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#265)

webdev (https://github.com/dart-lang/webdev/compare/12f2285..fe5b975):
  fe5b9758  2023-05-08  Anna Gringauze  Hide internal implementation details in type objects (#2103)

yaml (https://github.com/dart-lang/yaml/compare/54e8284..1f39ffe):
  1f39ffe  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#142)

yaml_edit (https://github.com/dart-lang/yaml_edit/compare/e05282b..763ca94):
  763ca94  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#51)

Change-Id: Ie2414a72f1377775a474ef976c2f9c797ed5b0a5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/302360
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Devon Carew <devoncarew@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
copybara-service bot pushed a commit that referenced this issue Oct 10, 2023
@devoncarew
[deps] rev dartdoc, mockito, native, protobuf, test, tools, web_socke…
7b79435 
…t_channel, webdriver

Revisions updated by `dart tools/rev_sdk_deps.dart`.

dartdoc (https://github.com/dart-lang/dartdoc/compare/524b2b6..5156398):
  5156398c  2023-10-09  Sam Rawlins  Fix sidebar links for pub packages (#3510)
  960bac41  2023-10-09  dependabot[bot]  Bump ossf/scorecard-action from 2.2.0 to 2.3.0 (#3513)
  affc5b44  2023-10-08  Sam Rawlins  Remove some old, unused options (#3511)
  c147aa19  2023-10-06  Sam Rawlins  Fix left sidebar (#3507)

mockito (https://github.com/dart-lang/mockito/compare/49859e4..47a5588):
  47a5588  2023-10-06  Ilya Yanok  Don't try to compare fakes to real objects
  6b9eab9  2023-10-06  Ilya Yanok  Undo the formatting fix
  5ad2ff4  2023-10-05  Ilya Yanok  Change default dummy value for `String` to contain some info
  78c650b  2023-10-05  Ilya Yanok  Use SDK 3.0.0 for stable tests
  adbe265  2023-10-04  Ilya Yanok  Use 3.1.3 as stable SDK

native (https://github.com/dart-lang/native/compare/fd21f5b..22f4481):
  22f4481  2023-10-10  Daco Harkes  [native_assets_builder] Fix pub warning in tests (#155)

protobuf (https://github.com/dart-lang/protobuf/compare/c16bc89..c559fe5):
  c559fe5  2023-10-10  Ömer Sinan Ağacan  Release protoc_plugin-21.1.2 (#881)
  32ed0fe  2023-10-09  Ömer Sinan Ağacan  Fix a bug in comment parsing (#879)

test (https://github.com/dart-lang/test/compare/367aa39..4341470):
  4341470a  2023-10-06  Nate Bosch  Mention integration_test as an ignored directory (#2115)

tools (https://github.com/dart-lang/tools/compare/f318c80..92c5c15):
  92c5c15  2023-10-10  Devon Carew  update to the latest package:dart_flutter_team_lints (#174)

web_socket_channel (https://github.com/dart-lang/web_socket_channel/compare/364013d..f3ac1bf):
  f3ac1bf  2023-10-06  Nate Bosch  Mention `ready` in the docs for `connect` (#287)

webdriver (https://github.com/google/webdriver.dart/compare/21976d6..eaf9c58):
  eaf9c58  2023-10-05  Nate Bosch  Spawn test server in a background isolate (#285)
  ccd01e5  2023-10-05  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#284)
  f753b3e  2023-10-05  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#283)
  6bd246f  2023-10-05  Devon Carew  require dart 3.0; add publishing automation (#282)

Change-Id: I83ec9986cc8acc60be76267c2d1127f237e2b5c3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/329943
Auto-Submit: Devon Carew <devoncarew@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-not-planned Closed as we don't intend to take action on the reported issue web-dart2js
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@kevmoo @jmesserly @sigmundch @rakudrama @kasperl @anders-sandholm