Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changelog: void arrow setters should allow any rhs type #29683

Closed
eernstg opened this issue May 22, 2017 · 1 comment
Closed

Changelog: void arrow setters should allow any rhs type #29683

eernstg opened this issue May 22, 2017 · 1 comment
Labels
area-documentation Prefer using 'type-documentation' and a specific area label.
Milestone
1.24

Comments

@eernstg
Copy link
Member

eernstg commented May 22, 2017

This is the changelog specific issue for #29679. For 1.24 we just need to change 'functions' to 'functions and setters'.
@eernstg eernstg added the area-documentation Prefer using 'type-documentation' and a specific area label. label May 22, 2017
@eernstg eernstg added this to the 1.24 milestone May 22, 2017
@eernstg eernstg mentioned this issue May 22, 2017
Closed
4 tasks
eernstg added a commit that referenced this issue May 22, 2017
@eernstg
Adjusted wording for "return anything from void =>" to include setters
ecd86d9 
Addresses issue #29683.

R=floitsch@google.com

Review-Url: https://codereview.chromium.org/2899753002 .
@eernstg
Copy link
Member Author

eernstg commented May 22, 2017

Closed by ecd86d9.

@eernstg eernstg closed this as completed May 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-documentation Prefer using 'type-documentation' and a specific area label.
Projects
None yet
Milestone
1.24
Development

No branches or pull requests
1 participant
@eernstg