Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dart.equals is slow #29772

Closed
vsmenon opened this issue Jun 1, 2017 · 0 comments
Closed

dart.equals is slow #29772

vsmenon opened this issue Jun 1, 2017 · 0 comments
Assignees
@leafpetersen
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures web-dev-compiler

Comments

@vsmenon
Copy link
Member

vsmenon commented Jun 1, 2017

Per @leafpetersen , the dart.equals appears hot in Angular change detection code. Looking at the code, we should be able to specialize quite a bit to the call site:

https://github.com/dart-lang/sdk/blob/master/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart#L629
@vsmenon vsmenon added web-dev-compiler dev-compiler-performance P1 A high priority bug; for example, a single project is unusable or has many test failures labels Jun 1, 2017
@vsmenon vsmenon added this to the 1.25 milestone Jun 1, 2017
@leafpetersen leafpetersen self-assigned this Jun 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leafpetersen leafpetersen

Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures web-dev-compiler
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vsmenon @leafpetersen