Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fasta doesn't support annotations on directives #30284

Closed
scheglov opened this issue Jul 27, 2017 · 0 comments
Closed

Fasta doesn't support annotations on directives #30284

scheglov opened this issue Jul 27, 2017 · 0 comments
Assignees
@scheglov
Labels
area-front-end Use area-front-end for front end / CFE / kernel format related issues. front-end-fasta

Comments

@scheglov
Copy link
Contributor

For code

@a library L; const a = null;

The corresponding Kernel Library.annotations is empty.

The same is for

@a import "foo.dart"; const a = b;

and

@a export "foo.dart"; const a = null;

Corresponding LibraryDependency.annotations are empty.
@scheglov scheglov added front-end-fasta area-front-end Use area-front-end for front end / CFE / kernel format related issues. labels Jul 27, 2017
@sigmundch sigmundch mentioned this issue Jul 27, 2017
Closed
51 tasks
whesse pushed a commit that referenced this issue Oct 16, 2017
@scheglov
Parse annotations for library directives.
1e6c488 
R=ahe@google.com, paulberry@google.com, sigmund@google.com

Bug: #30284
Change-Id: I9354e114eb2d603543a964030482af7ac9198760
Reviewed-on: https://dart-review.googlesource.com/12802
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
whesse pushed a commit that referenced this issue Oct 19, 2017
@scheglov
Parse metadata for import/export directives and resynthesize in Analy…
3fedd48 
…zer.

R=ahe@google.com, paulberry@google.com, sigmund@google.com

Bug: #30284
Change-Id: I57af6f4d58b6de39f13b9656af25f0be6949cf79
Reviewed-on: https://dart-review.googlesource.com/14363
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
whesse pushed a commit that referenced this issue Oct 24, 2017
@scheglov
Parse metadata for part directives and resynthesize in Analyzer.
ccbed2d 
R=ahe@google.com, paulberry@google.com, sigmund@google.com

Bug: #30284
Change-Id: Id869144a6fce170dbc74b0595b545238595be84d
Reviewed-on: https://dart-review.googlesource.com/15983
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scheglov scheglov

Labels
area-front-end Use area-front-end for front end / CFE / kernel format related issues. front-end-fasta
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@scheglov @peter-ahe-google