Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate String + in dartium code #3120

Closed
DartBot opened this issue May 17, 2012 · 3 comments
Closed

Eliminate String + in dartium code #3120

DartBot opened this issue May 17, 2012 · 3 comments
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-obsolete Closed as the reported issue is no longer relevant

Comments

@DartBot
Copy link

DartBot commented May 17, 2012

This issue was originally filed by @mhausner

Running dartium buildbot tests with String + support disabled fails. Please eliminate all use of String + from the code.

See CL 7718
Buildbot logs:
http://chromegw.corp.google.com/i/client.dash/builders/dartium-mac-inc/builds/1689
http://chromegw.corp.google.com/i/client.dash/builders/dartium-lucid64-inc/builds/2427

To run without support for String +, set allow_string_plus to false (on command line or in vm/parser.cc)
@DartBot
Copy link
Author

DartBot commented May 18, 2012

This comment was originally written by antonm@google.com

I don't think it's a problem with Dartium. The offending code belongs to lib/date.dart .

I'll fix it.

cc @floitschG.
Set owner to antonm@google.com.
Removed Area-Dartium label.
Added Area-Library, Started labels.

@DartBot
Copy link
Author

DartBot commented May 18, 2012

This comment was originally written by @mhausner

Thanks. There may be more than the lib/date.dart case. In particular, I haven't checked dom and html code.

@floitschG
Copy link
Contributor

Obsolete.

Added AssumedStale label.

@DartBot DartBot added Type-Defect area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-obsolete Closed as the reported issue is no longer relevant labels Apr 19, 2013
copybara-service bot pushed a commit that referenced this issue Sep 28, 2021
@szakarias
Bump pub version
730806b 
Changes:
```
> git log --format="%C(auto) %h %s" 15a46117da29cc572fba620241c83a2117cdae09..a817863ee93241ff36fce6856c6d12fd8fde0907
 a817863e Use pool for file reading (#3156)
 59237e29 Don't ask packageLister for availabe versions (#3151)
 f2f86c01 Fix analyze errors (#3148)
 39c9779c Environment credentials support (#3115)
 f0020823 Improved handling for authentication errors (#3120)
 1bb9f923 Migrate ignore.dart to null-safety (#3142)

```

Change-Id: I01d6637e3de8e523596394383393f5eda1a728c9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/214804
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Commit-Queue: Jonas Jensen <jonasfj@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-obsolete Closed as the reported issue is no longer relevant
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@floitschG @DartBot