Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kernel text printer doesn't properly parenthesize ((...) => expr) as type #31380

Closed
stereotype441 opened this issue Nov 15, 2017 · 0 comments
Closed
Assignees
Labels
area-front-end Use area-front-end for front end / CFE / kernel format related issues. front-end-kernel

Comments

@stereotype441
Copy link
Member

This arose during a code review: https://dart-review.googlesource.com/c/sdk/+/20907/1/pkg/front_end/testcases/inference/generic_methods_inference_error.dart.strong.expect#7

When an AsExpression contains a FunctionExpression, the text printer prints it as (...) => expr as type, which makes it look like the FunctionExpression contains the AsExpression. The text printer should add parentheses: ((...) => expr) as type.

It looks like it should be a pretty simple fix--I'll work on it if time allows. If someone on the kernel team wants to take over this bug from me, please feel free.

@stereotype441 stereotype441 self-assigned this Nov 15, 2017
@kmillikin kmillikin assigned kmillikin and unassigned stereotype441 Nov 16, 2017
@whesse whesse closed this as completed in 02511ce Nov 16, 2017
@kmillikin kmillikin added area-front-end Use area-front-end for front end / CFE / kernel format related issues. front-end-kernel and removed area-front-end Use area-front-end for front end / CFE / kernel format related issues. labels Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-front-end Use area-front-end for front end / CFE / kernel format related issues. front-end-kernel
Projects
None yet
Development

No branches or pull requests

2 participants