dart2js adds 144k over frog

[DartBot]

This issue was originally filed by prujoh...@gmail.com

---

Build 7996.

Attached the files. ZartWeb.dart.js is the dart2js version, zartweb.dart.js_ is the frog version.

Is this just extra debugging overhead that will be removed later?

---

Attachments:
ZartWeb.dart.js (1.31 MB)
zartweb.dart.js_ (1003.31 KB)

[peter-ahe-google]

We are working on bringing the code size down. This sounds like what we see on other programs.

If you can give us a copy of ZartWeb.dart, we can use it as a benchmark. Otherwise, I don't think that this bug makes sense to keep open. We know the output is too big, but it is virtually impossible to know when to close this bug without the sources.

---

Added Area-Dart2JS, NeedsInfo labels.

[DartBot]

This comment was originally written by prujohn...@gmail.com

---

Kasper suggested I open this. If the code size is expected to be larger at this point, then I see no reason to keep it open either. :)

[peter-ahe-google]

If Kasper wants the bug, then I think we should keep it.

---

Set owner to @kasperl.
Added Triaged label.

[kasperl]

This is definitely not solved yet, but we've made some progress. We've added liveness analysis (r8145) to get rid of some of many temporary variables that we used to keep around (like char0):

  var char$ = this._char$0();
  if (char$ === 45) {
    var char0 = this._nextChar$0();
  } else {
    char0 = char$;
  }

and we've removed the empty else clauses (r8149) to simplify code like this:

  if ($.get$length(this._buffer) === 0) {
    return '';
  } else {
  }

More to come. Maybe you can upload a new version of the dart2js version with these fixes and let us know if the changes help at all, John?

[DartBot]

This comment was originally written by pru...@gmail.com

---

Thanks for the update Kasper.

I'll keep checking it and post back the source when I see something improve. As of build 8192, I'm getting the same results (1.3mb). :)

[kasperl]

I'm very interesting in figuring out if our work on making (simple) switches compile to nicer code has helped here. I haven't found a place to grab hold of ZartWeb.dart yet, so even though I've grabbed a copy of the zart source base I still cannot really re-measure this myself.

[DartBot]

This comment was originally written by prujo...@gmail.com

---

Yes I haven't posted ZartWeb publicly. It has multiple dependencies and that's a bit tricky until PUB comes fully online. :)

There is definitely some positive progress. The JS file is down to 1.12mb (attached).

---

Attachment:
ZartWeb.dart.js (1.09 MB)

[kasperl]

So I guess I can update the summary to 'dart2js adds 144k over frog'? :-)

[DartBot]

This comment was originally written by prujohn...@gmail.com

---

Fine by me!

[kasperl]

Changed the title to: "dart2js adds 144k over frog".

[DartBot]

This comment was originally written by prujoh...@gmail.com

---

Big jump recently to 2.5mb. I see a lot of extra code re: noSuchMethod()

[kasperl]

Fix for the recent jump on the way: https://chromiumcodereview.appspot.com/10843022/.

[DartBot]

This comment was originally written by prujo...@gmail.com

---

Back down to 1.27mb :)

[kasperl]

We'll continue to push on code size (in particular once we've implemented all the new features for M1), but this bug has outlived its usefulness. Thanks for the report, John.

---

Added AssumedStale label.

[DartBot]

This comment was originally written by pruj...@gmail.com

---

Agreed.