-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Class docs for Datagram class are too brief and full of typos #33721
Comments
I should add that the RawDatagramSocket class docs are pretty anemic as well. |
For example, look at the documentation for |
There's also a number of completely undocumented members in this API, for example |
Documentation on RawDatagramSocket were too brief. This change also add documentation on SocketException, which previously doesn't have any documents. Bug: #33721 Bug: #35147 Change-Id: I6e33e5814c5af93ac7986de394ca1999f723091a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138886 Commit-Queue: Zichang Guo <zichangguo@google.com> Reviewed-by: Lasse R.H. Nielsen <lrn@google.com> Reviewed-by: Jonas Termansen <sortie@google.com>
Bug: #33721 Change-Id: I503c910f4a854dea0561687a06c760ad11ffc5dc Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/277663 Commit-Queue: Brian Quinlan <bquinlan@google.com> Reviewed-by: Alexander Aprelev <aam@google.com> Reviewed-by: Jonas Termansen <sortie@google.com>
Bug: #33721 Change-Id: I4e8f35cec8d3e689469a63826d118cfa2fe42218 CoreLibraryReviewExempt: Documentation-only change Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/277701 Reviewed-by: Alexander Aprelev <aam@google.com> Commit-Queue: Brian Quinlan <bquinlan@google.com>
If you just search for "Datagram" in the docs and end up in the Datagram class, the documentation is impenetrable and unhelpful. It should at a minimum point you towards RawDatagramSocket. Ideally it would have sample code.
This is misleading since it sounds like it's talking about a Dart package.
"sent"
The data doesn't contain this stuff.
"together".
The data contains the data? That makes no sense.
The text was updated successfully, but these errors were encountered: