Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement casts in Analyzer #3401

Closed
gbracha opened this issue Jun 6, 2012 · 8 comments
Closed

Implement casts in Analyzer #3401

gbracha opened this issue Jun 6, 2012 · 8 comments
Assignees
@bwilkerson
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion.
Milestone
M1

Comments

@gbracha
Copy link
Contributor

gbracha commented Jun 6, 2012

Section 10.30 of the draft 10.30 spec describes cast expressions of the form: e as T. These need to be implemented.
@bwilkerson
Copy link
Member

I added these questions to the Doc, but wasn't sure whether you got notification when comments were added.

I can't find the production "typeCast" referenced anywhere else in the grammer. What is the precedence of the "as" operator?

Is "as" a reserved word or a built-in identifier?

Set owner to @gbracha.

@gbracha
Copy link
Contributor Author

gbracha commented Jun 6, 2012

Good points. Spec patched to address these points. It's a built-in identifier and its precedence is the same as a type test (see 10.21, Relational Expressions)

Removed the owner.

@bwilkerson
Copy link
Member

Set owner to @bwilkerson.
Added this to the M1 milestone.
Added Started label.

@bwilkerson
Copy link
Member

http://codereview.chromium.org/10536031/

Added Fixed label.

@gbracha
Copy link
Contributor Author

gbracha commented Jun 15, 2012

Sorry, but we've had to change the spec so that null is accepted. Re-opening.

Added Started label.

@crelier
Copy link
Contributor

crelier commented Jun 25, 2012

Please, note that contrary to 'is', 'as' is not a reserved word. The current implementation of type cast in dartc fails language/pseudo_kw_test.

@scheglov
Copy link
Contributor

Yes, we know.
I don't see logic behind such difference, but... OK, we will fix the Editor.

@bwilkerson
Copy link
Member

http://codereview.chromium.org/10660012/

Added Fixed label.

@gbracha gbracha added Type-Defect area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. labels Jun 25, 2012
@gbracha gbracha added this to the M1 milestone Jun 25, 2012
copybara-service bot pushed a commit that referenced this issue May 16, 2023
@devoncarew
[deps] rev args, async, bazel_worker, benchmark_harness, boolean_sele…
94c2f65 
…ctor, browser_launcher, characters, cli_util, clock, collection, crypto, dartdoc, leak_tracker, lints

Revisions updated by `dart tools/rev_sdk_deps.dart`.

args (https://github.com/dart-lang/args/compare/1864048..f0f6cd2):
  f0f6cd2  2023-05-12  Devon Carew  blast_repo fixes (#243)

async (https://github.com/dart-lang/async/compare/0f368d3..d744058):
  d744058  2023-05-12  Devon Carew  blast_repo fixes (#242)

bazel_worker (https://github.com/dart-lang/bazel_worker/compare/1b86d3c..d9b389f):
  d9b389f  2023-05-12  Devon Carew  blast_repo fixes (#73)

benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/f81b042..e717ad4):
  e717ad4  2023-05-12  Devon Carew  blast_repo fixes (#90)

boolean_selector (https://github.com/dart-lang/boolean_selector/compare/7eed402..3a1c982):
  3a1c982  2023-05-15  Devon Carew  Update README.md (#48)
  23e08e0  2023-05-12  Devon Carew  blast_repo fixes (#47)

browser_launcher (https://github.com/dart-lang/browser_launcher/compare/551e101..40e4315):
  40e4315  2023-05-12  Devon Carew  blast_repo fixes (#45)

characters (https://github.com/dart-lang/characters/compare/2af6783..3ef8883):
  3ef8883  2023-05-15  Devon Carew  blast_repo fixes (#82)

cli_util (https://github.com/dart-lang/cli_util/compare/7234f17..5a49947):
  5a49947  2023-05-15  Devon Carew  blast_repo fixes (#83)

clock (https://github.com/dart-lang/clock/compare/6b9df3e..fe85908):
  fe85908  2023-05-15  Devon Carew  blast_repo fixes (#51)

collection (https://github.com/dart-lang/collection/compare/6abff47..db2da48):
  db2da48  2023-05-15  Devon Carew  blast_repo fixes (#288)

crypto (https://github.com/dart-lang/crypto/compare/4e9dde1..216931a):
  216931a  2023-05-15  Devon Carew  blast_repo fixes (#149)

dartdoc (https://github.com/dart-lang/dartdoc/compare/d01ddc5..2952f6b):
  2952f6bf  2023-05-16  Sam Rawlins  Simplify ToolConfiguration and other options code (#3414)
  0cf21c15  2023-05-12  Janice Collins  Extract fileName / fileType from ModelElement, LibraryContainer into FileStructure (#3413)
  2ae78bcc  2023-05-12  Sam Rawlins  Split sidebars out into separate HTML files (#3384)
  f00d0443  2023-05-11  Janice Collins  Housekeeping:  language version 3.0, analyzer deprecations, pubspec update (#3412)
  370477d2  2023-05-10  dependabot[bot]  Bump github/codeql-action from 2.3.2 to 2.3.3 (#3410)
  e8c5de44  2023-05-08  Janice Collins  Begin extracting file structure information from ModelElement (#3408)
  24af8a11  2023-05-04  Janice Collins  Add a hideConstantImplementations dartdoc directive (#3398)
  078d42fd  2023-05-03  Janice Collins  Change language feature wording based on review in #3401 (#3405)
  31088c1b  2023-05-03  dependabot[bot]  Bump github/codeql-action from 2.2.12 to 2.3.2 (#3403)
  60055b4e  2023-05-03  Sam Rawlins  Update validate-sdk-docs task to allow 20 libs (#3404)

leak_tracker (https://github.com/dart-lang/leak_tracker/compare/bc7f604..8ae200a):
  8ae200a  2023-05-15  Polina Cherkasova  - (#62)

lints (https://github.com/dart-lang/lints/compare/17276ec..72f107a):
  72f107a  2023-05-15  Devon Carew  blast_repo fixes (#120)
  6732fbc  2023-05-15  Devon Carew  blast_repo fixes (#119)

Change-Id: Ibbb1fcc530da01653fe325bdcf77f1c764887a81
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/303783
Auto-Submit: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bwilkerson bwilkerson

Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion.
Projects
None yet
Milestone
M1
Development

No branches or pull requests
4 participants
@scheglov @gbracha @bwilkerson @crelier