Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dart2js does not implement super.property #3407

Closed
DartBot opened this issue Jun 6, 2012 · 1 comment
Closed

dart2js does not implement super.property #3407

DartBot opened this issue Jun 6, 2012 · 1 comment
Labels
closed-duplicate Closed in favor of an existing report web-dart2js

Comments

@DartBot
Copy link

DartBot commented Jun 6, 2012

This issue was originally filed by rtimon...@gmail.com


What steps will reproduce the problem?

  1. Create class A, then class B extending A.
  2. Implement property getter in A, then override in B
  3. Call super.property from B property implementation
  4. Run app, all is fine
  5. Compile using dart2js, notice internal error

What is the expected output? What do you see instead?
no compile error, a compile error: "internal error: super property read not implemented"

What version of the product are you using? On what operating system?
Version 0.1.0.201205301156, Build 8124
Dart SDK version 8120, Dartium version
Ubuntu

Please provide any additional information below.

class A {
  String get gah() {
    return "merp";
  }
}
class B extends A {
  String get gah() {
    return "${super.gah}ie";
  }
}

@dgrove
Copy link
Contributor

dgrove commented Jun 8, 2012

this has been fixed.


Added Area-Dart2JS, Duplicate labels.
Marked as being merged into #3191.

@DartBot DartBot added Type-Defect web-dart2js closed-duplicate Closed in favor of an existing report labels Jun 8, 2012
copybara-service bot pushed a commit that referenced this issue May 4, 2022
Changes:
```
> git log --format="%C(auto) %h %s" a949b32..6068f47
 https://dart.googlesource.com/pub.git/+/6068f47c Fixing link example "User-Agent" (#3400)
 https://dart.googlesource.com/pub.git/+/cd0d6992 Make tests more agnostic to the test environment (#3402)
 https://dart.googlesource.com/pub.git/+/1f8db828 Fix retrieval of name in `pub global activate -sgit` (#3407)
 https://dart.googlesource.com/pub.git/+/ed63f212 Limit the number of concurrent precompilations (#3396)
 https://dart.googlesource.com/pub.git/+/d82f80a5 Fix crash when checking code with bad import (#3392)
 https://dart.googlesource.com/pub.git/+/b9ae624e Relative urls in lockfile for git urls (#3385)
 https://dart.googlesource.com/pub.git/+/62bb2440 Fix `dependency_services apply` for packages with relative imports (#3374)

```

Diff: https://dart.googlesource.com/pub.git/+/a949b329b1b51f5f3973a790e0a0a45897d837de~..6068f47c264ef790e16411b31b2c94ad6beb1ab6/
Change-Id: Ib18c2647e27a34d84005214b844351f314698611
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243321
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
Reviewed-by: Sarah Zakarias <zarah@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-duplicate Closed in favor of an existing report web-dart2js
Projects
None yet
Development

No branches or pull requests

2 participants