Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discontinue the deprecated screaming snake case constants from dart:io #34218

Closed
natebosch opened this issue Aug 22, 2018 · 10 comments
Closed

Discontinue the deprecated screaming snake case constants from dart:io #34218

natebosch opened this issue Aug 22, 2018 · 10 comments
Assignees
@stereotype441
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-io

Comments

@natebosch
Copy link
Member

Forking the conversation from #31813

We have added new lowercase constants and migrated all internal code, and external code authored by the Dart team to use it. We need to determine whether we want to remove the deprecated constants for Dart 3.0 (then figure out how to keep track of these things so we don't miss them for that release)

My vote would be to remove them. They'll be deprecated for a long time by that point and the migration is really easy to do.
@vsmenon vsmenon added area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-io labels Aug 22, 2018
@natebosch natebosch mentioned this issue Aug 22, 2018
Closed
6 tasks
@srawlins
Copy link
Member

Dart three-point-ohhhhhhh

@natebosch
Copy link
Member Author

@mit-mit - Have we decided on how we will collect and track these decisions? In this case we've discussed even removing them before Dart 3.0

@lrhn
Copy link
Member

lrhn commented Nov 23, 2021

Proof-of-concept: https://dart-review.googlesource.com/c/sdk/+/219791
(Proving that it's not that simple).

@mit-mit
Copy link
Member

mit-mit commented Nov 23, 2021

Does dart fix already support updating code away from these to their non-screaming equivalents?

@natebosch
Copy link
Member Author

Does dart fix already support updating code away from these to their non-screaming equivalents?

Most of them.

There are a couple that are not covered because dart fix does not have a way to express them yet.
#45393 (comment)

@mit-mit
Copy link
Member

mit-mit commented Feb 10, 2022

@natebosch the issue you linked to looks resolved, so does dart fix support them all now?

@natebosch
Copy link
Member Author

so does dart fix support them all now?

No. https://dart-review.googlesource.com/c/sdk/+/214068 attempts to use these fixes and the test failures show that there is still a problem. I forwarded you an internal thread with some more detail.

@mit-mit
Copy link
Member

mit-mit commented Mar 7, 2022

Updating title: Analysis of both internal and external code shows very little use of these long discontinued SCREAMING CASE APIs, so we're going ahead with the removal.

@mit-mit mit-mit changed the title Determine whether to delete the deprecated screaming snake case constants from dart:io Discontinue the deprecated screaming snake case constants from dart:io Mar 7, 2022
copybara-service bot pushed a commit that referenced this issue Mar 9, 2022
@stereotype441
Stop using deprecated "screaming caps" constants from dart:io
9872e9d 
Bug: #34218
Change-Id: I4215c0a2212d5c15972d9ffe4075c89d27c9081e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/235701
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
@timsneath
Copy link
Contributor

HOORAY! FANTASTIC! I CAN TURN MY CAPS LOCK KEY OFF NOW! 🥇

@mit-mit mit-mit mentioned this issue May 30, 2022
Closed
@mit-mit
Copy link
Member

mit-mit commented May 30, 2022 •
edited
Loading

There are a few more to remove in http: #49140
https://dart-review.googlesource.com/c/sdk/+/246962

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stereotype441 stereotype441

Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-io
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@srawlins @stereotype441 @vsmenon @timsneath @lrhn @natebosch @mit-mit