Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specification: Eliminate impossible dynamic errors #34521

Closed
eernstg opened this issue Sep 20, 2018 · 2 comments
Closed

Specification: Eliminate impossible dynamic errors #34521

eernstg opened this issue Sep 20, 2018 · 2 comments
Labels
area-specification (deprecated) Deprecated: use area-language and a language- label. type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
Dart Language Specification

Comments

@eernstg
Copy link
Member

eernstg commented Sep 20, 2018

Having changed all warnings to errors (about 13 will be reverted soon, but the vast majority are still errors), we have several elements of the language specification that are concerned with the dynamic behavior in situations that now cannot arise (because the specification says nothing about how to run programs with errors).

We should traverse the entire spec for dynamic errors and eliminate these elements. We may want to add commentary saying that the given situation cannot arise, with a reference to the location where the error is specified.
@eernstg eernstg added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) area-specification (deprecated) Deprecated: use area-language and a language- label. labels Sep 20, 2018
@eernstg eernstg added this to To do in Dart Language Specification via automation Sep 20, 2018
@eernstg
Copy link
Member Author

eernstg commented Jan 18, 2019

Addressed in this CL.

@eernstg eernstg moved this from To do to In progress in Dart Language Specification Jan 18, 2019
@eernstg eernstg moved this from In progress to Needs review in Dart Language Specification Jan 18, 2019
@eernstg
Copy link
Member Author

eernstg commented Jan 21, 2019

Said CL landed as 649c4e6.

@eernstg eernstg closed this as completed Jan 21, 2019
Dart Language Specification automation moved this from Needs review to Done Jan 21, 2019
dart-bot pushed a commit that referenced this issue Jan 21, 2019
@eernstg
Revised all spec occurrences of "dynamic error"/"dynamic type error"
649c4e6 
.. and checked that they can occur also in Dart 2; added a comment
about why this is so, on each of them. Also, got rid of the term
"run-time error": the majority of references to errors at run time
were "dynamic error", and now that is the term used everywhere.

Cf. #34521.

Change-Id: I7579c84a8d52199524770fb91c64804173ed533d
Reviewed-on: https://dart-review.googlesource.com/c/90243
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
lrhn pushed a commit to dart-lang/language that referenced this issue Sep 4, 2020
@eernstg
Revised all spec occurrences of "dynamic error"/"dynamic type error"
4e63a8a 
.. and checked that they can occur also in Dart 2; added a comment
about why this is so, on each of them. Also, got rid of the term
"run-time error": the majority of references to errors at run time
were "dynamic error", and now that is the term used everywhere.

Cf. dart-lang/sdk#34521.

Change-Id: I7579c84a8d52199524770fb91c64804173ed533d
Reviewed-on: https://dart-review.googlesource.com/c/90243
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-specification (deprecated) Deprecated: use area-language and a language- label. type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
Dart Language Specification
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eernstg