Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The code in CheckEntryPoint provides a very cryptic message when it encounters a class that needs the entry point pragma #35170

Closed
a-siva opened this issue Nov 14, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@a-siva
Copy link
Contributor

commented Nov 14, 2018

The code in CheckEntryPoint in dart_api_impl.cc which checks that a class accessed using the C++ API has the vm entry point pragma produces a very cryptic crash message.

It would be nice if the message indicated which class was being accessed from which library so that the class could be easily fixed.

The code RELEASE_ASSERT(klass.has_pragma())
could be converted to an explicit check with an error message and a call to FATAL

@mraleph

This comment has been minimized.

Copy link
Contributor

commented Nov 15, 2018

I already have a fix for this yesterday in https://dart-review.googlesource.com/c/sdk/+/84435

@dart-bot dart-bot closed this in a1a38da Nov 15, 2018

@a-siva

This comment has been minimized.

Copy link
Contributor Author

commented Nov 15, 2018

Didn't realize you were working on this, this was going to be Liam's starter bug to make sure he had the correct git setup for the Dart and Flutter projects. I will find him another one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.