Committers can preapprove new failures from the commit queue #35289
Labels
area-infrastructure
Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes.
Projects
Comments
vsmenon
added
the
area-infrastructure
dart-bot
pushed a commit
that referenced
this issue
Nov 30, 2018
This change lets committers preapprove new failing tests based on commit queue / dry run results for CQ builders, such that the CQ builder stays green when the change is submitted. The current implementation does not support changing one test from a failing mode to another failing mode. It will work, but if the corresponding CI builder cycles before the changelist is submitted, it will become red until the changelist is submitted. This will be addressed in the future. Likewise approving a builder after a preapproval will undo the preapproval unless the changelist has been submitted and the corresponding CI builder has cycled. Bug: #35289 Change-Id: Ie43df4439a27a3472c5178cb7c6af69292cf70e4 Reviewed-on: https://dart-review.googlesource.com/c/85601 Reviewed-by: William Hesse <whesse@google.com>
|
Failures can be approved from try runs, however the CQ itself doesn't allow it. It still needs support for three way comparison (recipe underway). |
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It should be possible to approve new failures from commit queue / dry run results before submitting the change, such that the CI builder never turns red in the first place.
The text was updated successfully, but these errors were encountered: