Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement three way comparison between previous, current, and approved results #35298

Closed
sortie opened this issue Nov 30, 2018 · 1 comment
Closed

Implement three way comparison between previous, current, and approved results #35298

sortie opened this issue Nov 30, 2018 · 1 comment
Assignees
@sortie
Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes.
Projects
Status file free workflow

Comments

@sortie
Copy link
Contributor

sortie commented Nov 30, 2018

compare_results.dart compares previous and current results. However, it's also relevant whether the results are approved. This is needed so it can tell you why a bot is red, and to support the getting new failures past the CQ if the new failing changes are all approved.
@sortie sortie created this issue from a note in Status file free workflow (In progress) Nov 30, 2018
@sortie sortie added the area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. label Nov 30, 2018
@sortie sortie self-assigned this Nov 30, 2018
dart-bot pushed a commit that referenced this issue Dec 4, 2018
@sortie
[infra] Implement 3-way comparison with approved_results in compare_r…
52183f2 
…esults.

Bug: #35298
Change-Id: Ie5bd1101cae8eddd65ad5aa53c8f2d97c6548b2b
Reviewed-on: https://dart-review.googlesource.com/c/85702
Reviewed-by: William Hesse <whesse@google.com>
@sortie
Copy link
Contributor Author

sortie commented Dec 7, 2018

Done.

@sortie sortie closed this as completed Dec 7, 2018
Status file free workflow automation moved this from In progress to Done Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sortie sortie

Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes.
Projects
No open projects
Status file free workflow
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sortie