New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide if new analyzer API needs a way to override UriConverter #35308

Open
stereotype441 opened this Issue Dec 3, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@stereotype441
Member

stereotype441 commented Dec 3, 2018

As mentioned in code review, the new analyzer API replaces the UriResolver class with UriConverter, but it doesn't provide a way for clients to override the choice of UriConverter or supply their own class implementing the interface. However, at least two existing clients in build contain subclasses of UriResolver:

  • bazel_codegen (2 classes named BuildAssetUriResolver)
  • build_resolvers (1 class named _AssetUriResolver)
    There may be other uses in the Google internal codebase.

We need to understand the use cases for these client classes and ensure that the new analyzer API supports them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment