Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide if new analyzer API needs a way to override UriConverter #35308

Open
stereotype441 opened this issue Dec 3, 2018 · 0 comments
Open

Decide if new analyzer API needs a way to override UriConverter #35308

stereotype441 opened this issue Dec 3, 2018 · 0 comments
Labels
analyzer-api Issues that impact the public API of the analyzer package area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable type-task A well-defined stand-alone task

Comments

@stereotype441
Copy link
Member

As mentioned in code review, the new analyzer API replaces the UriResolver class with UriConverter, but it doesn't provide a way for clients to override the choice of UriConverter or supply their own class implementing the interface. However, at least two existing clients in build contain subclasses of UriResolver:

  • bazel_codegen (2 classes named BuildAssetUriResolver)
  • build_resolvers (1 class named _AssetUriResolver)
    There may be other uses in the Google internal codebase.

We need to understand the use cases for these client classes and ensure that the new analyzer API supports them.

@stereotype441 stereotype441 added type-task A well-defined stand-alone task area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on analyzer-api Issues that impact the public API of the analyzer package labels Dec 3, 2018
@srawlins srawlins added the type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable label Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzer-api Issues that impact the public API of the analyzer package area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable type-task A well-defined stand-alone task
Projects
None yet
Development

No branches or pull requests

2 participants