Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows support for the new workflow #35367

Closed
sortie opened this issue Dec 10, 2018 · 1 comment
Closed

Windows support for the new workflow #35367

sortie opened this issue Dec 10, 2018 · 1 comment
Assignees
@sortie
Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes.
Projects
Status file free workflow

Comments

@sortie
Copy link
Contributor

sortie commented Dec 10, 2018 •
edited
Loading

The new tools/approve_results.dart and tools/test.dart scripts needs to work on Windows.

This is complicated by the tools running gsutil.py, which causes the VM to fail because it's not a valid Windows application. depot_tools does not supply a .bat file to wrap it, so I'm making one. Then we can invoke that program instead.
@sortie sortie created this issue from a note in Status file free workflow (In progress) Dec 10, 2018
@sortie sortie self-assigned this Dec 10, 2018
@sortie sortie added the area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. label Dec 10, 2018
dart-bot pushed a commit that referenced this issue Dec 11, 2018
@sortie
[infra] Add Windows support for gsutil.py.
0e08c26 
The Windows PATH search finds gsutil.py and attempts to invoke that, which
is not a valid Windows application. Instead invoke it's accompanying batch
file.

Bug: #35367
Change-Id: I396809e18dabdc59664bbda34e0832cc7dd4082f
Reviewed-on: https://dart-review.googlesource.com/c/86767
Reviewed-by: William Hesse <whesse@google.com>
@sortie
Copy link
Contributor Author

sortie commented Dec 11, 2018

Done.

@sortie sortie closed this as completed Dec 11, 2018
Status file free workflow automation moved this from In progress to Done Dec 11, 2018
abeir pushed a commit to abeir/depot_tools that referenced this issue Apr 24, 2024
@sortie
Add windows .bat file for gsutil.py.
ed4ed04 
gsutil.py is cumbersome to use on Windows, unlike on Linux and Mac. This
change adds a batch file like the ones for gclient and other tools.

Bug: dart-lang/sdk#35367
Change-Id: Ib33dc27573de5485ae93b525002f5fbcb3a5f4d1
abeir pushed a commit to abeir/depot_tools that referenced this issue Apr 24, 2024
@sortie
Add windows .bat file for gsutil.py.
7c79a38 
gsutil.py is cumbersome to use on Windows, unlike on Linux and Mac. This
change adds a batch file like the ones for gclient and other tools.

Bug: dart-lang/sdk#35367
Change-Id: Ib33dc27573de5485ae93b525002f5fbcb3a5f4d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sortie sortie

Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes.
Projects
No open projects
Status file free workflow
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sortie