Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fast iteration on status-free workflow #35873

Closed
sigmundch opened this issue Feb 6, 2019 · 4 comments
Closed

fast iteration on status-free workflow #35873

sigmundch opened this issue Feb 6, 2019 · 4 comments
Assignees
Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@sigmundch
Copy link
Member

When iterating locally on a feature, it is very useful to run a single test repeatedly (e.g. when debugging or making changes to a compiler).

Could we have a way to iterate on a single test and have accurate results that reflect the current results in the status-free system?


Context:

In the old workflow, we normally would use a selector to run a few tests or a single test. For example:

./tools/test.py -m release -c dart2js -r d8 language_2/set_literals/invalid_set_literal_test/29

This has the unfortunate effect that the test fails whenever .status files inaccurately apply to dart2js. For example, the test above produces a compile-time error, but it is incorrectly labeled as "MissingCompileTimeError" under $fasta section in language_2_kernel.status.

This issue may go away when everyone moves to the new workflow, but it can be very confusing to work with at this time, and because we don't maintain status files anymore, this seems unavoidable.

The new workflow suggest that we run tests like:

./tools/test.dart -b name-of-our-bot

This however runs all tests run by that bot.

Could we make test.dart accept a selector? For example:

./tools/test.dart -b name-of-our-bot language_2/set_literals/invalid_set_literal_test/...

/cc @fishythefish

@sigmundch sigmundch added the area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. label Feb 6, 2019
@sortie sortie self-assigned this Feb 14, 2019
@sortie sortie added P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) labels Feb 14, 2019
@sortie
Copy link
Contributor

sortie commented Feb 14, 2019

Thanks for the feedback. We heard this from a few sources and I have a CL in review that fixes the problem (https://dart-review.googlesource.com/c/sdk/+/92780) -- I believe that should meet your needs.

@sortie
Copy link
Contributor

sortie commented Feb 15, 2019

Hi. I've implemented what you need now. See --help of test.dart for how it works. Any additional parameters following -- are forwarded to test.py.

@sortie
Copy link
Contributor

sortie commented Feb 15, 2019

@askeksa-google You also asked about this feature, it's now done.

@sigmundch
Copy link
Member Author

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

2 participants