Code completion not working after ... (spread)

[jwren]

No completions from the Analysis Server at the |:

void main() async {
  final list1 = [1, 2, 3];

  final list2 = [0, ...li|];

  print(list2);
}

Issue originally filed at https://youtrack.jetbrains.com/issue/WEB-38571

[scheglov]

https://dart-review.googlesource.com/c/sdk/+/100523

[scheglov]

There is a couple of other cases when completion does not work perfectly, even with this CL.

1. No completion for the loop variable in IfElement, e.g. no name in [for (var name in names) ^].
2. No else completion in IfElement.

[stereotype441]

We decided it's not necessary to try to cherry-pick a fix into Dart 2.3.

[aadilmaan]

Did this change land already?

[scheglov]

Yes, see the dart-bot message just above.

But #36733 (comment) is not addresses yet.

[stereotype441]

@scheglov are the remaining issues likely to be addressed in D24? If not let's change the milestone.

[scheglov]

I moved it from D24 to Future.

[bwilkerson]

Completion now works after the for loop parts, but still doesn't complete else in the following example

void f(List<String> names) {
  var x = [if (names.isNotEmpty) names[0] el ];
}

[srawlins]

As spread completions work now, this issue is closed. I've opened a new issue for the unrelated completion that @bwilkerson brings up in #36733 (comment): #48837