Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor webapp-template could include more required files #3678

Closed
DartBot opened this issue Jun 15, 2012 · 8 comments
Closed

Editor webapp-template could include more required files #3678

DartBot opened this issue Jun 15, 2012 · 8 comments
Assignees
Labels
type-enhancement A request for a change that isn't a bug
Milestone

Comments

@DartBot
Copy link

DartBot commented Jun 15, 2012

This issue was originally filed by sammcca...@google.com


Creating a new web application in the editor is a nice quick start, but it's missing some things you'll need, e.g. css file and pubspec.
Additionally the html file is '<appname>.html' when the entrypoint is almost universally index.html.

I'd find this most useful:
  pubspec.yaml
  index.html
  appname.dart
  styles.css
  

@DartBot
Copy link
Author

DartBot commented Jun 15, 2012

This comment was originally written by sammcca...@google.com


(The latter is particularly annoying because renaming the HTML file crashes the editor, but that's a different bug...)

@keertip
Copy link
Contributor

keertip commented Jun 15, 2012

Removed Type-Defect label.
Added Type-Enhancement, Area-Editor, Triaged labels.

@devoncarew
Copy link
Member

The latter is particularly annoying because renaming the HTML file crashes the editor, but that's a different bug

Do you know, is there a bug for this?

@DartBot
Copy link
Author

DartBot commented Jun 15, 2012

This comment was originally written by sammcca...@google.com


Oops, assumed this was well known, as I haven't used the editor for months and this was the first thing that happened :-)

http://code.google.com/p/dart/issues/detail?id=3683

@keertip
Copy link
Contributor

keertip commented Jun 15, 2012

Added this to the Later milestone.

@devoncarew
Copy link
Member

Set owner to @devoncarew.

@devoncarew
Copy link
Member

We prettified the sample app that the wizard creates and added a css file. We decided to keep the name of the html file foo.html instead of index.html. The user would have several web apps in their workspace all w/ index.html as their entry points, and selecting an app from the manage launches dialog (for instance) could be confusing.


Added Fixed label.

@clayberg
Copy link

Removed this from the Later milestone.
Added this to the M1 milestone.

@DartBot DartBot added this to the M1 milestone Sep 18, 2012
@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed type-enhancement labels Mar 1, 2016
copybara-service bot pushed a commit that referenced this issue Dec 1, 2022
Changes:
```
> git log --format="%C(auto) %h %s" 4fd2051..21aa23f
 https://dart.googlesource.com/pub.git/+/21aa23f1 Revert "Create output folder if it doesn't exist in the precompiler (#3676)" (#3677)
 https://dart.googlesource.com/pub.git/+/04f7bce8 Don't consider resolution outdated in dev-releases (#3678)
 https://dart.googlesource.com/pub.git/+/74473e12 Create output folder if it doesn't exist in the precompiler (#3676)
 https://dart.googlesource.com/pub.git/+/5bfd68b1 Avoid .incremental.dill.incremental.dill in temporary file name (#3675)
 https://dart.googlesource.com/pub.git/+/c3870bc1 Unskip test (#3671)

```

Diff: https://dart.googlesource.com/pub.git/+/4fd2051bb8060ea2f2e02b13dfeb2f793d197994..21aa23f148a428ae4dd97a27ecc70b08c1328089/
Change-Id: Ie5060563cc3f96b0bc52e542f7a7b19d17fefd8f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/273223
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

5 participants