Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[benchmarks/ffi] Generate repetitive benchmark code #37581

Closed
dcharkes opened this issue Jul 19, 2019 · 3 comments
Closed

[benchmarks/ffi] Generate repetitive benchmark code #37581

dcharkes opened this issue Jul 19, 2019 · 3 comments
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-ffi

Comments

@dcharkes
Copy link
Contributor

The dart:ffi benchmarks have repetitive patterns in the benchmark code. This is hard to maintain and easy to get wrong. We should use code generation to address this.

Follow up of #36247.
@dcharkes dcharkes added area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-ffi area-benchmarks labels Jul 19, 2019
@dcharkes dcharkes self-assigned this Jul 19, 2019
@sjindel-google
Copy link
Contributor

@dcharkes Can you please assign an estimate?

@dcharkes
Copy link
Contributor Author

The estimate includes the part of figuring out how to generate Dart code in the SDK.

Generated benchmarks are under review, still some tweaking to be done there:
https://dart-review.googlesource.com/c/sdk/+/114201
https://dart-review.googlesource.com/c/sdk/+/114068

@dcharkes dcharkes removed their assignment Oct 24, 2019
@dcharkes
Copy link
Contributor Author

Low prio, removing assignment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-ffi
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dcharkes @sjindel-google