Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collect benchmarks and improve FFI performance #36247

Closed
13 of 15 tasks
dcharkes opened this issue Mar 18, 2019 · 6 comments
Closed
13 of 15 tasks

Collect benchmarks and improve FFI performance #36247

dcharkes opened this issue Mar 18, 2019 · 6 comments
Assignees
@dcharkes
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. library-ffi

Comments

@dcharkes
Copy link
Contributor

dcharkes commented Mar 18, 2019 •
edited
Loading

@vsmenon vsmenon added the area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. label Mar 18, 2019
@sjindel-google sjindel-google changed the title dart:ffi benchmarks Collect benchmarks and improve FFI performance Apr 23, 2019
@sjindel-google sjindel-google mentioned this issue Apr 23, 2019
Closed
@sjindel-google sjindel-google mentioned this issue Apr 23, 2019
Closed
@sjindel-google
Copy link
Contributor

https://github.com/santetis/libsodium.dart contains a crypto benchmark

@dcharkes dcharkes self-assigned this Apr 29, 2019
@dcharkes
Copy link
Contributor Author

dcharkes commented May 6, 2019

Note to self. Loop invariant code motion should garbage collect the Pointer object too early, as that would call finalizers too early. See TypedData, which has the same issue.

@sjindel-google
Copy link
Contributor

To scope this for the MVP release: we will understand the performance of FFI operations and implement any "low-hanging" optimisations.

@dcharkes
Copy link
Contributor Author

Arm32 benchmarks on Linux are blocked by #36309.

dart-bot pushed a commit that referenced this issue Jun 24, 2019
@dcharkes
[vm/ffi] Tests for aliasing
7142345 
Issue: #36247
Change-Id: I81f4cb1d34bc25efe6bc4c2d14615356ac52262f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106906
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Auto-Submit: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
This was referenced Jul 15, 2019
Open
Closed
dart-bot pushed a commit that referenced this issue Jul 19, 2019
@dcharkes @sortie
[benchmarks/ffi] Add micro and macro benchmarks for dart:ffi
fbf13f5 
Adds micro benchmarks to measure low level (1) C memory reads and writes from Dart and (2) calls from Dart into C. This CL also adds a macro benchmark to measure overall performance using BoringSSL to digest data. The shared libraries are precompiled for Linux and live in cipd packages. The benchmarks run on all hardware architectures (with the exception of Linux'es hardfp on Arm32: #36309).

Issue: #36247

Change-Id: I8dfb30cc66a26a2942bb09194c5eb0da0b6ca1b5
Cq-Include-Trybots: luci.dart.try:benchmark-linux-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108724
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Jonas Termansen <sortie@google.com>
Auto-Submit: Daco Harkes <dacoharkes@google.com>
@sjindel-google
Copy link
Contributor

We need benchmarks for FFI callbacks also.

This was referenced Sep 2, 2019
Open
Closed
@dcharkes
Copy link
Contributor Author

dcharkes commented Sep 2, 2019

Closing in favor of the new issues.

@dcharkes dcharkes closed this as completed Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dcharkes dcharkes

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. library-ffi
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vsmenon @dcharkes @sjindel-google