New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration engine does not support extensions #39387
Comments
Some support has been added, but there is now at least one crash: class C<T> {}
void f(C<List> x) {}
extension E on C<List> {
g() => f(this);
} (In edge_builder's _thisOrSuper, Additionally the case of extending Function is not handled: extension CurryFunction<R, S, T> on R Function(S, T) {
/// Curry a binary function with its first argument.
R Function(T) curry(S first) => (T second) => this(first, second);
} I am checking in two failing tests. |
Bug: #39387 Change-Id: I2187db2433255fd950789942712d215c2472db4f Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149005 Reviewed-by: Paul Berry <paulberry@google.com> Commit-Queue: Samuel Rawlins <srawlins@google.com>
Bug: #39387 Change-Id: I037d29355dc86c071acc8dcc6f417a95e96e9728 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/172200 Reviewed-by: Samuel Rawlins <srawlins@google.com> Commit-Queue: Paul Berry <paulberry@google.com>
This functionality is working now, the test was just broken. Bug: #39387 Change-Id: I088a3bd40ac438d0a9cd2356badfaf9513aa4bbb Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/172280 Reviewed-by: Samuel Rawlins <srawlins@google.com> Commit-Queue: Paul Berry <paulberry@google.com>
As of 1c7fe71, the null safety migration tool has been removed from active development and retired. No further work on the tool is planned. If you still need help, or you believe this issue has been closed in error, please feel free to reopen. |
The migration engine needs to support extensions. This entails several things:
this
should be considered nullableThe text was updated successfully, but these errors were encountered: