Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/html/js_typed_interop* tests failing #41361

Closed
scheglov opened this issue Apr 6, 2020 · 0 comments
Closed

lib/html/js_typed_interop* tests failing #41361

scheglov opened this issue Apr 6, 2020 · 0 comments
Assignees
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test).

Comments

@scheglov
Copy link
Contributor

scheglov commented Apr 6, 2020

analyzer-asserts-strong-linux:lib/html/js_typed_interop_side_cast_exp_test/01 broke (Pass -> CompileTimeError, expected Pass)
analyzer-asserts-strong-linux:lib/html/js_typed_interop_side_cast_exp_test/none broke (Pass -> CompileTimeError, expected Pass)
analyzer-asserts-strong-linux:lib/html/js_typed_interop_type2_test/01 broke (Pass -> CompileTimeError, expected Pass)
analyzer-asserts-strong-linux:lib/html/js_typed_interop_type2_test/none broke (Pass -> CompileTimeError, expected Pass)
analyzer-asserts-strong-linux:lib/html/js_typed_interop_type3_test/01 broke (Pass -> CompileTimeError, expected Pass)
analyzer-asserts-strong-linux:lib/html/js_typed_interop_type3_test/02 broke (Pass -> CompileTimeError, expected Pass)
analyzer-asserts-strong-linux:lib/html/js_typed_interop_type3_test/none broke (Pass -> CompileTimeError, expected Pass)
analyzer-asserts-weak-linux:lib/html/js_typed_interop_side_cast_exp_test/01 broke (Pass -> CompileTimeError, expected Pass)
analyzer-asserts-weak-linux:lib/html/js_typed_interop_side_cast_exp_test/none broke (Pass -> CompileTimeError, expected Pass)
analyzer-asserts-weak-linux:lib/html/js_typed_interop_type2_test/01 broke (Pass -> CompileTimeError, expected Pass)
analyzer-asserts-weak-linux:lib/html/js_typed_interop_type2_test/none broke (Pass -> CompileTimeError, expected Pass)
analyzer-asserts-weak-linux:lib/html/js_typed_interop_type3_test/01 broke (Pass -> CompileTimeError, expected Pass)
analyzer-asserts-weak-linux:lib/html/js_typed_interop_type3_test/02 broke (Pass -> CompileTimeError, expected Pass)
analyzer-asserts-weak-linux:lib/html/js_typed_interop_type3_test/none broke (Pass -> CompileTimeError, expected Pass)

See the log for details.

For example:

===============================================================================================================================\
| analyzer-asserts-strong-linux:lib/html/js_typed_interop_side_cast_exp_test/01 broke (Pass -> CompileTimeError, expected Pass) |
\===============================================================================================================================/

--- Command "dart2analyzer" (took 50ms):
DART_CONFIGURATION=ReleaseX64NNBD out/ReleaseX64NNBD/dart-sdk/bin/dartanalyzer --experimental-trust-js-interop-type-annotations --enable-experiment=non-nullable --ignore-unrecognized-flags --packages=/b/s/w/ir/cache/builder/sdk/.packages --format=machine --no-hints /b/s/w/ir/cache/builder/sdk/out/ReleaseX64NNBD/generated_tests/lib/html/js_typed_interop_side_cast_exp_test_01.dart

exit code:
1

stderr:
ERROR|COMPILE_TIME_ERROR|MISSING_DEFAULT_VALUE_FOR_PARAMETER|/b/s/w/ir/cache/builder/sdk/out/ReleaseX64NNBD/generated_tests/lib/html/js_typed_interop_side_cast_exp_test_01.dart|34|27|1|The parameter 'x' can't have a value of 'null' because of its type, so it must either be a required parameter or have a default value.
ERROR|COMPILE_TIME_ERROR|MISSING_DEFAULT_VALUE_FOR_PARAMETER|/b/s/w/ir/cache/builder/sdk/out/ReleaseX64NNBD/generated_tests/lib/html/js_typed_interop_side_cast_exp_test_01.dart|20|27|1|The parameter 'x' can't have a value of 'null' because of its type, so it must either be a required parameter or have a default value.
ERROR|COMPILE_TIME_ERROR|MISSING_DEFAULT_VALUE_FOR_PARAMETER|/b/s/w/ir/cache/builder/sdk/out/ReleaseX64NNBD/generated_tests/lib/html/js_typed_interop_side_cast_exp_test_01.dart|27|27|1|The parameter 'x' can't have a value of 'null' because of its type, so it must either be a required parameter or have a default value.

--- Re-run this test:
python tools/test.py -n analyzer-asserts-strong-linux lib/html/js_typed_interop_side_cast_exp_test/01

The error at the line 20 is for x here, it is named and no required, so the spec says that this is an error.

@JS()
@anonymous
class A {
  external int get x;
  external factory A({int x});
}
@scheglov scheglov added the area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). label Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test).
Projects
None yet
Development

No branches or pull requests

2 participants