Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dart:html all APIs indicating a SecureContext should be nullable #41944

Open
sigmundch opened this issue May 18, 2020 · 1 comment
Open

dart:html all APIs indicating a SecureContext should be nullable #41944

sigmundch opened this issue May 18, 2020 · 1 comment
Assignees
@srujzs
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. library-html web-libraries Issues impacting dart:html, etc., libraries

Comments

@sigmundch
Copy link
Member

Some DOM APIs indicate that they are available in a SecureContext only.

If the program is loaded under https:// there is a value, otherwise (e.g. under http://) it is undefined.

Turns out that was why deviceMemory was failing on some tests (see https://developer.mozilla.org/en-US/docs/Web/API/Device_Memory_API)
@sigmundch sigmundch added web-libraries Issues impacting dart:html, etc., libraries library-html area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. labels May 18, 2020
@sigmundch
Copy link
Member Author

@srujzs - this may be less relevant at the moment, but something to keep in mind when we start reenabling non-nullable properties that are supported across browsers.

@sigmundch sigmundch mentioned this issue May 19, 2020
Open
@srujzs srujzs self-assigned this Jun 3, 2020
dart-bot pushed a commit that referenced this issue Jul 1, 2020
@srujzs
[dart:html] Add secure context logic to mdnreader
4559562 
Bug: #41944

Note that the compatibility data on secure contexts is fairly
sparse and has missing information. There are only two APIs that
have secure context info on them and they're already marked as
incompatible.

Change-Id: Iaf9ecb7a916c8ac20b32e1ea92ed44981f675659
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152044
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srujzs srujzs

Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. library-html web-libraries Issues impacting dart:html, etc., libraries
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sigmundch @srujzs