Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pub is missing the --(no-)sound-null-safety flags #42465

Closed
mit-mit opened this issue Jun 24, 2020 · 6 comments · Fixed by dart-lang/pub#2542
Closed

pub is missing the --(no-)sound-null-safety flags #42465

mit-mit opened this issue Jun 24, 2020 · 6 comments · Fixed by dart-lang/pub#2542
Labels
area-sdk Use area-sdk for general purpose SDK issues (packaging, distribution, …).

Comments

@mit-mit
Copy link
Member

mit-mit commented Jun 24, 2020

Pub should support the null safety mode flags: --no-sound-null-safety / --sound-null-safety.

When used, they should be passed on to the VM (note that the flag there is yet to be renamed: #41853)

@kevmoo
Copy link
Member

kevmoo commented Jun 25, 2020

@mit-mit should this be filed on the pub repo? Or are you talking about dartdev?

@kevmoo kevmoo added the area-sdk Use area-sdk for general purpose SDK issues (packaging, distribution, …). label Jun 25, 2020
@mit-mit
Copy link
Member Author

mit-mit commented Jun 25, 2020

I'm not sure actually. Don't we generally need this flag in all binaries that run/compile code + on all dartdev verbs that run/compile code? cc @leafpetersen

@sigurdm
Copy link
Contributor

sigurdm commented Jun 25, 2020

  • What is the timing of this. Can this be available already?
  • Will the old names still be available, or do we have to transition how we forward the flag?

@mit-mit
Copy link
Member Author

mit-mit commented Jun 25, 2020

We will simply rename the existing flags, they have not been mentioned in public documentation yet, and the rename is thus not considered breaking.

@a-siva when do you plan on renaming #41853? The pub flag should probably be landed after that item is done.

@mit-mit
Copy link
Member Author

mit-mit commented Jul 9, 2020

@sigurdm the VM flag has now been renamed

@kevmoo
Copy link
Member

kevmoo commented Jul 28, 2020

Has a CL gone through the SDK to bring in this version of pub?

Perhaps we should wait to close it until that happens @sigurdm

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-sdk Use area-sdk for general purpose SDK issues (packaging, distribution, …).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants