Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress Observatory message until DDS has started #42727

Closed
bkonyi opened this issue Jul 16, 2020 · 0 comments
Closed

Suppress Observatory message until DDS has started #42727

bkonyi opened this issue Jul 16, 2020 · 0 comments
Assignees
@bkonyi
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. pkg-dds For issues related to the Dart Development Service
Milestone
September Release...

Comments

@bkonyi
Copy link
Contributor

bkonyi commented Jul 16, 2020

There's a race condition which can between the time that the VM service starts and DDS connects that can cause DDS to fail to connect if another client connects before DDS. The Observatory listening message should not be printed until DDS has already connected.
@bkonyi bkonyi added area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. pkg-dds For issues related to the Dart Development Service labels Jul 16, 2020
@bkonyi bkonyi self-assigned this Jul 16, 2020
dart-bot pushed a commit that referenced this issue Jul 30, 2020
@bkonyi
[ VM/ DDS ] Temporarily disable DDS for beta release
8dc4833 
#42727 isn't expected to be fixed
before the next beta release. Disabling DDS temporarily until a proper
fix has been landed.

Change-Id: Ib3233e75a115caa9625f1e96d136b0f6abc5f72e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156343
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
@bkonyi bkonyi mentioned this issue Aug 4, 2020
Closed
@bkonyi bkonyi added this to the September 2020 milestone Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bkonyi bkonyi

Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. pkg-dds For issues related to the Dart Development Service
Projects
None yet
Milestone
September Release 2020
Development

No branches or pull requests
1 participant
@bkonyi