Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand test coverage for null-safety to all configurations #43463

Open
4 of 7 tasks
athomas opened this issue Sep 17, 2020 · 5 comments
Open
4 of 7 tasks

Expand test coverage for null-safety to all configurations #43463

athomas opened this issue Sep 17, 2020 · 5 comments
Assignees
@athomas
Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. P2 A bug or feature request we're likely to work on

Comments

@athomas
Copy link
Member

athomas commented Sep 17, 2020 •
edited
Loading

  • CFE
  • Analyzer
  • VM (this will need to be broken down further)
  • DDC
  • dart2js
  • Ensure that there is a way to compare the results of the new builders to their legacy counterparts.
  • Check that the remaining configurations are either out-of-scope or add coverage for them as well.
@athomas athomas added P1 A high priority bug; for example, a single project is unusable or has many test failures area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. labels Sep 17, 2020
@athomas athomas self-assigned this Sep 17, 2020
@athomas
Copy link
Member Author

athomas commented Sep 17, 2020

@franklinyow FYI

@athomas
Copy link
Member Author

athomas commented Sep 17, 2020

In the scope of this issue, builders will start to be added as nightly builders. Once it has been determined which have the greatest discrepancies, some builders will be moved over to be commit triggered.

dart-bot pushed a commit that referenced this issue Sep 17, 2020
@athomas
[infra] Add the remaining CFE NNBD configurations to the Luci config
9ec8350 
The added configurations will run nightly for now.

#43463

Change-Id: I9ee6a2e667c20451585bdbbff8744123e6fe03af
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/163201
Reviewed-by: William Hesse <whesse@google.com>
dart-bot pushed a commit that referenced this issue Sep 17, 2020
@athomas
[infra] Add remaining CFE nnbd builders to the test matrix
52559eb 
#43463

Change-Id: I4156a8de90526190e1c977178f126e30d420f6e5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/163205
Reviewed-by: William Hesse <whesse@google.com>
dart-bot pushed a commit that referenced this issue Sep 18, 2020
@athomas
[infra] Use the correct dimensions for the new CFE nnbd builders
4604c6f 
#43463

Change-Id: I5624621014bf3e219e5d0728b8aab1dbf6a2fc7f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/163341
Auto-Submit: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: William Hesse <whesse@google.com>
dart-bot pushed a commit that referenced this issue Sep 18, 2020
@athomas
[infra] Increase number of shards on the CFE nnbd builders
2364105 
Shards running on slower machines timed out. This will double the number
of shards giving them enough headroom to finish.

#43463

TBR=whesse@google.com

Change-Id: I1d12fd42fea3b19fce3900f7ecfb5e567fd720bd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/163420
Reviewed-by: Alexander Thomas <athom@google.com>
dart-bot pushed a commit that referenced this issue Sep 29, 2020
@athomas
[infra] Add additional nnbd VM builders
c3d37c1 
See also Luci configuration here:
https://dart-review.googlesource.com/c/sdk/+/164084

#43463

Change-Id: I071c8c6055004574cbe35f14a28e0cd8c468988f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164164
Reviewed-by: William Hesse <whesse@google.com>
dart-bot pushed a commit that referenced this issue Sep 29, 2020
@athomas
[infra] Add remaining standard nnbd VM configurations to the Luci config
33a05b4 
#43463

Change-Id: I9abb58ee66dcb2db832004228a4196c985a40f47
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164084
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
dart-bot pushed a commit that referenced this issue Oct 8, 2020
@athomas
[infra] Add analyzer NNBD macOS and Windows builders to the test matrix
bebfd10 
#43463

Change-Id: Ibba0f6738714d2b2917613bcfc70f31c95527f1a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/166423
Reviewed-by: Karl Klose <karlklose@google.com>
dart-bot pushed a commit that referenced this issue Oct 8, 2020
@athomas
[infra] Add analyzer NNBD macOS and Windows builders to the Luci config
d362126 
#43463

Change-Id: I1a3e528371774d51f108230ec39a85363b587eb7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/166424
Reviewed-by: Karl Klose <karlklose@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
@vsmenon
Copy link
Member

vsmenon commented Aug 4, 2021

@athomas - is this obsolete?

@athomas
Copy link
Member Author

athomas commented Aug 6, 2021

@vsmenon Unfortunately not. We still need to do more work there.

@vsmenon
Copy link
Member

vsmenon commented Jun 7, 2022

@athomas - is this still a P1?

@athomas athomas added P2 A bug or feature request we're likely to work on and removed P1 A high priority bug; for example, a single project is unusable or has many test failures labels Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@athomas athomas

Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. P2 A bug or feature request we're likely to work on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vsmenon @athomas