-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dartanalyzer not generating diagnostics for pubspec.yaml files #43529
Comments
That's working as expected (though not necessarily as intended :-) ). The command-line analyzer only analyzes |
Aha. That's helpful and yeah, a little surprising. I'm not sure it's entirely work there either though?
More importantly, IntelliJ isn't reporting the diagnostic either. I'm not sure if that's an IntelliJ issue or server yet. |
hi! I'm still pretty new to this codebase so my conclusions may be incorrect, but I had taken a look at this issue a while back, and I think for the command-line analyzer, the reason why it's not analyzing |
Thanks for taking a look @walnutdust! My attention has been on server, with a proof of concept up for discussion here: https://dart-review.googlesource.com/c/sdk/+/164249 The CLI would need some updating as well. |
Is this currently just an issue with |
It's an issue in IDEs as well. |
The command-line The analysis server reports some diagnostics, but wasn't reporting lints for them, even though we have implemented a couple of lints. Phil's CL will fix server so that lints are produced by server. |
The rub is that |
Ah, ok. I'll rename this to reflect that this is (or will soon be) |
As for Brian's comment, even if you specify a pubspec on the CLI lints won't be run. |
See: #43529 Change-Id: Iaf05102b3f6473913d900286c31779cdb1d59926 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164249 Commit-Queue: Phil Quitslund <pquitslund@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
UPDATE: the Flutter Engine roll was blocked on a false positive in the newly reporting |
Disables the fix in https://dart-review.googlesource.com/c/sdk/+/164249 pending a fix to `sort_pub_dependencies` which is producing a false positive that is blocking the Flutter engine roll. See: #43529 See: dart-lang/linter#2271 Change-Id: Ica6262153b89259ba67b5a43eeeafe2bdd482b44 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/166703 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Dan Field <dnfield@google.com>
UPDATE: false alarm. Lint was fine after all. Staging change for re-landing. 👍 |
To reproduce,
sort_pub_dependencies
(No issues are reported in IntelliJ either.)
The linter binary does pick these up (and explains why our tests haven't noticed the regression):
/fyi @jonasfj
The text was updated successfully, but these errors were encountered: