Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration tool UI should distinguish files being migrated from those already migrated or not being migrated yet #44101

Closed
stereotype441 opened this issue Nov 6, 2020 · 1 comment
Closed

Migration tool UI should distinguish files being migrated from those already migrated or not being migrated yet #44101

stereotype441 opened this issue Nov 6, 2020 · 1 comment
Assignees
@srawlins
Labels
area-migration (deprecated) Deprecated: this label is no longer actively used (was: issues with the `dart migrate` tool). NNBD Issues related to NNBD Release P1 A high priority bug; for example, a single project is unusable or has many test failures type-enhancement A request for a change that isn't a bug
Projects
Null Safety Stable release
Milestone
January Beta Rele...

Comments

@stereotype441
Copy link
Member

(Reported by Tijo Jose)

When partially migrating a package, either for the first time or for an already partially migrated package, it would be helpful to be able to see which files are being migrated within the tool itself.

Currently, the left pane of the tool shows all files in the package with no way of distinguishing files that are already migrated, files that will be migrated in this run of the migration tool, and files that won't be migrated until later.

(Note that the functionality of having files that won't be migrated until later isn't currently exposed in the public-facing migration tool; exposing that publicly should be part of addressing this issue.)
@stereotype441 stereotype441 added P1 A high priority bug; for example, a single project is unusable or has many test failures area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. analyzer-nnbd-migration NNBD Issues related to NNBD Release labels Nov 6, 2020
@stereotype441 stereotype441 added area-migration (deprecated) Deprecated: this label is no longer actively used (was: issues with the `dart migrate` tool). and removed analyzer-nnbd-migration area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. labels Nov 16, 2020
@srawlins srawlins self-assigned this Nov 17, 2020
dart-bot pushed a commit that referenced this issue Nov 19, 2020
@srawlins
Migrator: Land front-end support for 'migration status' check boxes
db0a23f 
These check boxes are hidden behind a parameter that must be changed during
development; it is not wired to a public-facing flag.

The check boxes are styled, and are connected to the starting status of each
compilation unit (already migrated, opted out, migrating).

The check boxes can be toggled, but just for mocking purposes; their status is
not connected to the back end. The directory check boxes are not wired to the
status of their children.

Screenshot of checkboxes w/o colors: https://screenshot.googleplex.com/43XBRWsMPgbQXik

Screenshot of check boxes w/ colors: https://screenshot.googleplex.com/3bhJqcnmeV4sGNm
* dark green - already migrated; file is not being changed.
* light green - file is being migrated now.
* orange un-checked - file is being opted out, initial migration,
  file will gain opt-out comment.
* grey un-checked - staying opted out, file is not being changed.
* indeterminate - folder has multiple states inside.

Bug: #44124 and
Change-Id: I49daf1f52544024ec1c6d8d5cf3c59515c7db3a7
     #44101
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/172821
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
@franklinyow franklinyow added this to Opened in Null Safety Stable release via automation Nov 19, 2020
dart-bot pushed a commit that referenced this issue Nov 25, 2020
@srawlins
Migrator: Implement check boxes on directories
1b07887 
Checking and unchecking a directory toggles the status of all child files which
are 'migrating' or 'opting out.' Files which are already migrated do not
change.

Checking and unchecking a file updates the status of all parent directories.
Directories with both 'migrating' and 'opting out' files are 'indeterminate'.

The difference between 'file' and 'directory' NavigationTreeNodes was
getting too hairy so I split into two subclasses.

Removed the keepingOptedOut status and added the indeterminate status.

Bug: #44101
Change-Id: Iea1a8c07b08c3d7956db51ca372437093457fe7f
     #44124
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/173600
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
dart-bot pushed a commit that referenced this issue Dec 1, 2020
@srawlins
dart migrate: Move title bar and add 'Migrate' check box next to title
17226bb 
This check box displays whether a file is migrating, opting out, or
already migrated. The check box can be clicked to toggle between
migrating and opting out. Clicking the check box updates status in the
navigation tree. Clicking on check boxes updates the status in the
title bar.

Screenshot here: https://screenshot.googleplex.com/9z9v9L5DHhBXzEU.png

In terms of the HTML, a new parent above '.content' div was added:
the '.file' div, which includes a '.title-bar' div above the '.content'
div.

Bug: #44101 and
Change-Id: I021f0dd873119ae801e29faa92e97fe48d03ef3c
#44124
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174440
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
dart-bot pushed a commit that referenced this issue Dec 1, 2020
@scheglov
Revert "dart migrate: Move title bar and add 'Migrate' check box next…
7c5df72 
… to title"

This reverts commit 17226bb.

Reason for revert: has unrelated tools/abiversions changes

Original change's description:
> dart migrate: Move title bar and add 'Migrate' check box next to title
>
> This check box displays whether a file is migrating, opting out, or
> already migrated. The check box can be clicked to toggle between
> migrating and opting out. Clicking the check box updates status in the
> navigation tree. Clicking on check boxes updates the status in the
> title bar.
>
> Screenshot here: https://screenshot.googleplex.com/9z9v9L5DHhBXzEU.png
>
> In terms of the HTML, a new parent above '.content' div was added:
> the '.file' div, which includes a '.title-bar' div above the '.content'
> div.
>
> Bug: #44101 and
> Change-Id: I021f0dd873119ae801e29faa92e97fe48d03ef3c
> #44124
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174440
> Commit-Queue: Samuel Rawlins <srawlins@google.com>
> Reviewed-by: Paul Berry <paulberry@google.com>

TBR=paulberry@google.com,srawlins@google.com

Change-Id: I8b8433d47390df91201a365f5aa54c7fb835d997
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: #44101 and
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174385
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
dart-bot pushed a commit that referenced this issue Dec 2, 2020
@srawlins
Reland "dart migrate: Move title bar and add 'Migrate' check box next…
89811d9 
… to title"

This is a reland of 17226bb

Remove generated files

Original change's description:
> dart migrate: Move title bar and add 'Migrate' check box next to title
>
> This check box displays whether a file is migrating, opting out, or
> already migrated. The check box can be clicked to toggle between
> migrating and opting out. Clicking the check box updates status in the
> navigation tree. Clicking on check boxes updates the status in the
> title bar.
>
> Screenshot here: https://screenshot.googleplex.com/9z9v9L5DHhBXzEU.png
>
> In terms of the HTML, a new parent above '.content' div was added:
> the '.file' div, which includes a '.title-bar' div above the '.content'
> div.
>
> Bug: #44101 and
> Change-Id: I021f0dd873119ae801e29faa92e97fe48d03ef3c
> #44124
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174440
> Commit-Queue: Samuel Rawlins <srawlins@google.com>
> Reviewed-by: Paul Berry <paulberry@google.com>

Bug: #44101 and
Change-Id: Iefada3e2fc8cbbc767cfc539204dc51b369888a2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174720
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
dart-bot pushed a commit that referenced this issue Dec 9, 2020
@srawlins
dart migrate: Implement incremental migration in backend
88de6b4 
This is still hiding behind a flag pending final review.

Bug: #44101 and
Change-Id: I01b7cb07b3fde7ac67105034b0c4057cb8a69771
     #44124
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175402
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
@franklinyow franklinyow added this to the January 2021 milestone Jan 5, 2021
@devoncarew devoncarew moved this from Open to In Progress in Null Safety Stable release Jan 7, 2021
@franklinyow franklinyow added the type-enhancement A request for a change that isn't a bug label Jan 8, 2021
@devoncarew
Copy link
Member

This is complete.

Null Safety Stable release automation moved this from In Progress to Closed Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srawlins srawlins

Labels
area-migration (deprecated) Deprecated: this label is no longer actively used (was: issues with the `dart migrate` tool). NNBD Issues related to NNBD Release P1 A high priority bug; for example, a single project is unusable or has many test failures type-enhancement A request for a change that isn't a bug
Projects
No open projects
Null Safety Stable release
  
Closed
Milestone
January Beta Release (2.12)
Development

No branches or pull requests
4 participants
@srawlins @stereotype441 @devoncarew @franklinyow